From: "tip-bot2 for Leo Yan" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Leo Yan <leo.yan@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Mark Rutland <mark.rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Robert Walker <robert.walker@arm.com>,
Suzuki Poulouse <suzuki.poulose@arm.com>,
coresight ml <coresight@lists.linaro.org>,
linux-arm-kernel@lists.infradead.org,
Arnaldo Carvalho de Melo <acme@redhat.com>, x86 <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [tip: perf/core] perf cs-etm: Fix unsigned variable comparison to zero
Date: Thu, 19 Mar 2020 14:10:43 -0000 [thread overview]
Message-ID: <158462704338.28353.16418800886208337652.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20200219021811.20067-6-leo.yan@linaro.org>
The following commit has been merged into the perf/core branch of tip:
Commit-ID: bc010dd657ee0309276c88ab828b9ad156f75b31
Gitweb: https://git.kernel.org/tip/bc010dd657ee0309276c88ab828b9ad156f75b31
Author: Leo Yan <leo.yan@linaro.org>
AuthorDate: Wed, 19 Feb 2020 10:18:11 +08:00
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitterDate: Wed, 11 Mar 2020 10:48:44 -03:00
perf cs-etm: Fix unsigned variable comparison to zero
The variable 'offset' in function cs_etm__sample() is u64 type, it's not
appropriate to check it with 'while (offset > 0)'; this patch changes to
'while (offset)'.
Signed-off-by: Leo Yan <leo.yan@linaro.org>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Mike Leach <mike.leach@linaro.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Robert Walker <robert.walker@arm.com>
Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
Cc: coresight ml <coresight@lists.linaro.org>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lore.kernel.org/lkml/20200219021811.20067-6-leo.yan@linaro.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/cs-etm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
index 87d9943..62d2f9b 100644
--- a/tools/perf/util/cs-etm.c
+++ b/tools/perf/util/cs-etm.c
@@ -962,7 +962,7 @@ static inline u64 cs_etm__instr_addr(struct cs_etm_queue *etmq,
if (packet->isa == CS_ETM_ISA_T32) {
u64 addr = packet->start_addr;
- while (offset > 0) {
+ while (offset) {
addr += cs_etm__t32_instr_size(etmq,
trace_chan_id, addr);
offset--;
next prev parent reply other threads:[~2020-03-19 14:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 2:18 [PATCH v5 0/5] perf cs-etm: Fix synthesizing instruction samples Leo Yan
2020-02-19 2:18 ` Leo Yan
2020-02-19 2:18 ` [PATCH v5 1/5] perf cs-etm: Swap packets for " Leo Yan
2020-02-19 2:18 ` Leo Yan
2020-03-19 14:10 ` [tip: perf/core] " tip-bot2 for Leo Yan
2020-02-19 2:18 ` [PATCH v5 2/5] perf cs-etm: Continuously record last branch Leo Yan
2020-02-19 2:18 ` Leo Yan
2020-03-19 14:10 ` [tip: perf/core] " tip-bot2 for Leo Yan
2020-02-19 2:18 ` [PATCH v5 3/5] perf cs-etm: Correct synthesizing instruction samples Leo Yan
2020-02-19 2:18 ` Leo Yan
2020-03-19 14:10 ` [tip: perf/core] " tip-bot2 for Leo Yan
2020-02-19 2:18 ` [PATCH v5 4/5] perf cs-etm: Optimize copying last branches Leo Yan
2020-02-19 2:18 ` Leo Yan
2020-03-19 14:10 ` [tip: perf/core] " tip-bot2 for Leo Yan
2020-02-19 2:18 ` [PATCH v5 5/5] perf cs-etm: Fix unsigned variable comparison to zero Leo Yan
2020-02-19 2:18 ` Leo Yan
2020-03-19 14:10 ` tip-bot2 for Leo Yan [this message]
2020-03-10 5:43 ` [PATCH v5 0/5] perf cs-etm: Fix synthesizing instruction samples Leo Yan
2020-03-10 5:43 ` Leo Yan
2020-03-10 11:45 ` Arnaldo Carvalho de Melo
2020-03-10 11:45 ` Arnaldo Carvalho de Melo
2020-03-10 12:01 ` Leo Yan
2020-03-10 12:01 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158462704338.28353.16418800886208337652.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robert.walker@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.