From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 0/4] objtool,perf: Use shared x86 insn decoder
Date: Fri, 30 Aug 2019 15:40:20 -0300 [thread overview]
Message-ID: <20190830184020.GG28011@kernel.org> (raw)
In-Reply-To: <cover.1567118001.git.jpoimboe@redhat.com>
Em Thu, Aug 29, 2019 at 05:41:17PM -0500, Josh Poimboeuf escreveu:
> It's kind of silly that we have *three* identical copies of the x86 insn
> decoder in the kernel tree. Make it approximately 50% less silly by
> reducing that number to two.
Ok, I fixed up some minor conflicts with my perf/core branch and will
submit this together with the other things to the container builds and
then push it upstream, collected Peter and Masami's Acks.
- Arnaldo
> Josh Poimboeuf (4):
> objtool: Move x86 insn decoder to a common location
> perf: Update .gitignore file
> perf intel-pt: Remove inat.c from build dependency list
> perf intel-pt: Use shared x86 insn decoder
>
> .../{objtool => }/arch/x86/include/asm/inat.h | 0
> .../arch/x86/include/asm/inat_types.h | 0
> .../{objtool => }/arch/x86/include/asm/insn.h | 0
> .../arch/x86/include/asm/orc_types.h | 0
> tools/{objtool => }/arch/x86/lib/inat.c | 0
> tools/{objtool => }/arch/x86/lib/insn.c | 0
> .../arch/x86/lib/x86-opcode-map.txt | 0
> .../arch/x86/tools/gen-insn-attr-x86.awk | 0
> tools/objtool/Makefile | 4 +-
> tools/objtool/arch/x86/Build | 4 +-
> tools/objtool/arch/x86/decode.c | 4 +-
> tools/objtool/sync-check.sh | 12 +-
> tools/perf/.gitignore | 3 +
> tools/perf/arch/x86/tests/insn-x86.c | 2 +-
> tools/perf/arch/x86/util/archinsn.c | 2 +-
> tools/perf/check-headers.sh | 11 +-
> tools/perf/util/intel-pt-decoder/Build | 22 +-
> .../intel-pt-decoder/gen-insn-attr-x86.awk | 392 ------
> tools/perf/util/intel-pt-decoder/inat.c | 82 --
> tools/perf/util/intel-pt-decoder/inat.h | 230 ----
> tools/perf/util/intel-pt-decoder/inat_types.h | 15 -
> tools/perf/util/intel-pt-decoder/insn.c | 593 ---------
> tools/perf/util/intel-pt-decoder/insn.h | 216 ----
> .../intel-pt-decoder/intel-pt-insn-decoder.c | 10 +-
> .../util/intel-pt-decoder/x86-opcode-map.txt | 1072 -----------------
> 25 files changed, 34 insertions(+), 2640 deletions(-)
> rename tools/{objtool => }/arch/x86/include/asm/inat.h (100%)
> rename tools/{objtool => }/arch/x86/include/asm/inat_types.h (100%)
> rename tools/{objtool => }/arch/x86/include/asm/insn.h (100%)
> rename tools/{objtool => }/arch/x86/include/asm/orc_types.h (100%)
> rename tools/{objtool => }/arch/x86/lib/inat.c (100%)
> rename tools/{objtool => }/arch/x86/lib/insn.c (100%)
> rename tools/{objtool => }/arch/x86/lib/x86-opcode-map.txt (100%)
> rename tools/{objtool => }/arch/x86/tools/gen-insn-attr-x86.awk (100%)
> delete mode 100644 tools/perf/util/intel-pt-decoder/gen-insn-attr-x86.awk
> delete mode 100644 tools/perf/util/intel-pt-decoder/inat.c
> delete mode 100644 tools/perf/util/intel-pt-decoder/inat.h
> delete mode 100644 tools/perf/util/intel-pt-decoder/inat_types.h
> delete mode 100644 tools/perf/util/intel-pt-decoder/insn.c
> delete mode 100644 tools/perf/util/intel-pt-decoder/insn.h
> delete mode 100644 tools/perf/util/intel-pt-decoder/x86-opcode-map.txt
>
> --
> 2.20.1
--
- Arnaldo
next prev parent reply other threads:[~2019-08-30 18:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 22:41 [PATCH 0/4] objtool,perf: Use shared x86 insn decoder Josh Poimboeuf
2019-08-29 22:41 ` [PATCH 1/4] objtool: Move x86 insn decoder to a common location Josh Poimboeuf
2019-09-02 8:16 ` [tip: perf/core] " tip-bot2 for Josh Poimboeuf
2019-08-29 22:41 ` [PATCH 2/4] perf: Update .gitignore file Josh Poimboeuf
2019-09-02 8:16 ` [tip: perf/core] " tip-bot2 for Josh Poimboeuf
2019-08-29 22:41 ` [PATCH 3/4] perf intel-pt: Remove inat.c from build dependency list Josh Poimboeuf
2019-09-02 8:16 ` [tip: perf/core] " tip-bot2 for Josh Poimboeuf
2019-08-29 22:41 ` [PATCH 4/4] perf intel-pt: Use shared x86 insn decoder Josh Poimboeuf
2019-08-30 19:59 ` Arnaldo Carvalho de Melo
2019-08-30 20:06 ` Arnaldo Carvalho de Melo
2019-08-30 20:10 ` Josh Poimboeuf
2019-09-02 8:16 ` [tip: perf/core] " tip-bot2 for Josh Poimboeuf
2019-08-30 7:19 ` [PATCH 0/4] objtool,perf: " Peter Zijlstra
2019-08-30 15:20 ` Masami Hiramatsu
2019-08-30 15:41 ` Arnaldo Carvalho de Melo
2019-08-30 18:40 ` Arnaldo Carvalho de Melo [this message]
2019-08-30 19:00 ` Arnaldo Carvalho de Melo
2019-08-30 19:31 ` Josh Poimboeuf
2019-08-30 19:48 ` Arnaldo Carvalho de Melo
2019-08-31 1:51 ` Masami Hiramatsu
2019-08-31 20:19 ` Arnaldo Carvalho de Melo
2019-09-01 2:36 ` Masami Hiramatsu
2019-09-02 8:16 ` [tip: perf/core] objtool: Update sync-check.sh from perf's check-headers.sh tip-bot2 for Arnaldo Carvalho de Melo
2019-09-02 8:16 ` [tip: perf/core] objtool: Ignore intentional differences for the x86 insn decoder tip-bot2 for Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830184020.GG28011@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.