Re: [PATCH 0/6] perf scripts python: exported-sql-viewer.py: Add Time chart by CPU

From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] perf scripts python: exported-sql-viewer.py: Add Time chart by CPU
Date: Thu, 3 Oct 2019 10:43:40 -0300	[thread overview]
Message-ID: <20191003134340.GB9369@kernel.org> (raw)
In-Reply-To: <20191003132531.GA9369@kernel.org>

Em Thu, Oct 03, 2019 at 10:25:31AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Oct 03, 2019 at 02:01:16PM +0300, Adrian Hunter escreveu:
> > On 6/09/19 11:57 AM, Adrian Hunter wrote:
> > > On 21/08/19 11:32 AM, Adrian Hunter wrote:
> > >> Hi
> > >>
> > >> These patches to exported-sql-viewer.py, add a time chart based on context
> > >> switch information.  Context switch information was added to the database
> > >> export fairly recently, so the chart menu option will only appear if
> > >> context switch information is in the database.  Refer to the Exported SQL
> > >> Viewer Help option for more information about the chart.
> > >>
> > >>
> > >> Adrian Hunter (6):
> > >>       perf scripts python: exported-sql-viewer.py: Add LookupModel()
> > >>       perf scripts python: exported-sql-viewer.py: Add HBoxLayout and VBoxLayout
> > >>       perf scripts python: exported-sql-viewer.py: Add global time range calculations
> > >>       perf scripts python: exported-sql-viewer.py: Tidy up Call tree call_time
> > >>       perf scripts python: exported-sql-viewer.py: Add ability for Call tree to open at a specified task and time
> > >>       perf scripts python: exported-sql-viewer.py: Add Time chart by CPU
> > >>
> > >>  tools/perf/scripts/python/exported-sql-viewer.py | 1555 +++++++++++++++++++++-
> > >>  1 file changed, 1531 insertions(+), 24 deletions(-)
> > > 
> > > Any comments?
> > > 
> > 
> > ping
> 
> Nice stuff, but please next time, when you add a new UI accessible
> visualization, provide precise steps to collect, then generate the DB
> and finally run the GUI, so that interested people (like me, when
> testing) can follow those instructions and compare the result described
> to the graph the test would see following these instructions.
> 
> I'm trying to do that now.

The F1 help text helps in that direction, but only once you're in the
GUI.

I did limited testing this time, couldn't get what is in the help text
in the GUI, close but not exactly, I'm applying, since this doesn't
affects anything outside these scripts and I think that if some set of
instructions, which I encourage you to detail next time, are followed,
then the expected result looks promising.

- Arnaldo