From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Jin Yao <yao.jin@linux.intel.com>,
Song Liu <songliubraving@fb.com>,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH 0/5] Improve objdump parsing, fix LLVM objdump
Date: Thu, 10 Oct 2019 11:36:44 -0700 [thread overview]
Message-ID: <20191010183649.23768-1-irogers@google.com> (raw)
The objdump command line is piped through grep and expand meaning
failures don't surface. Refactor symbol__disassemble so that it manages
the memory for the read line, as well as trimming and expanding tabs.
Correct the objdump flag '--no-show-raw' to be '--no-show-raw-insn'
which binutils objdump permissively allows but fails with LLVM objdump.
Ian Rogers (5):
perf annotate: avoid reallocation in objdump parsing
perf annotate: use run-command.h to fork objdump
perf annotate: don't pipe objdump output through grep
perf annotate: don't pipe objdump output through expand
perf annotate: fix objdump --no-show-raw-insn flag
tools/perf/util/annotate.c | 195 +++++++++++++++++++++++++------------
1 file changed, 131 insertions(+), 64 deletions(-)
--
2.23.0.581.g78d2f28ef7-goog
next reply other threads:[~2019-10-10 18:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 18:36 Ian Rogers [this message]
2019-10-10 18:36 ` [PATCH 1/5] perf annotate: avoid reallocation in objdump parsing Ian Rogers
2019-10-14 14:15 ` Arnaldo Carvalho de Melo
2019-10-21 23:19 ` [tip: perf/core] perf annotate: Avoid " tip-bot2 for Ian Rogers
2019-10-10 18:36 ` [PATCH 2/5] perf annotate: use run-command.h to fork objdump Ian Rogers
2019-10-14 14:18 ` Arnaldo Carvalho de Melo
2019-10-15 0:35 ` Ian Rogers
2019-10-21 23:19 ` [tip: perf/core] perf annotate: Use libsubcmd's " tip-bot2 for Ian Rogers
2019-10-10 18:36 ` [PATCH 3/5] perf annotate: don't pipe objdump output through grep Ian Rogers
2019-10-14 14:19 ` Arnaldo Carvalho de Melo
2019-10-21 23:19 ` [tip: perf/core] perf annotate: Don't pipe objdump output through 'grep' command tip-bot2 for Ian Rogers
2019-10-10 18:36 ` [PATCH 4/5] perf annotate: don't pipe objdump output through expand Ian Rogers
2019-10-14 14:24 ` Arnaldo Carvalho de Melo
2019-10-21 23:19 ` [tip: perf/core] perf annotate: Don't pipe objdump output through 'expand' command tip-bot2 for Ian Rogers
2019-10-10 18:36 ` [PATCH 5/5] perf annotate: fix objdump --no-show-raw-insn flag Ian Rogers
2019-10-14 14:24 ` Arnaldo Carvalho de Melo
2019-10-21 23:19 ` [tip: perf/core] perf annotate: Fix " tip-bot2 for Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010183649.23768-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.