Re: [PATCH v2] perf tests: Fix out of bounds memory access

From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>,
	linux-kernel@vger.kernel.org,
	Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCH v2] perf tests: Fix out of bounds memory access
Date: Thu, 7 Nov 2019 21:35:07 +0800	[thread overview]
Message-ID: <20191107133507.GB32679@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20191107120643.GA11372@kernel.org>

On Thu, Nov 07, 2019 at 09:06:43AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Nov 07, 2019 at 06:20:29PM +0800, Leo Yan escreveu:
> > On Thu, Nov 07, 2019 at 10:42:26AM +0100, Jiri Olsa wrote:
>  
> > [...]
>  
> > > > To fix this issue, we will use evlist__open() and evlist__close() pair
> > > > functions to prepare and cleanup context for evlist; so 'evsel->id' and
> > > > 'evsel->ids' can be initialized properly when invoke do_test() and avoid
> > > > the out of bounds memory access.
>  
> > > right, we need to solve this on libperf level, so it's possible
> > > to call mmap/munmap multiple time without close/open.. I'll try
> > > to send something, but meanwhile this is good workaround
> > > 
> > > Reviewed-by: Jiri Olsa <jolsa@kernel.org>
>  
> > Thanks for reviewing, Jiri.
>  
> > You are welcome to send us the fixing patches, I am glad to test it on
> > qemu_arm.
> 
> Thanks, applied after adding:
> 
> Fixes: ee74701ed8ad ("perf tests: Add test to check backward ring buffer")
> Cc: stable@vger.kernel.org # v4.10+
> 
> Please consider doing it next time,

Thanks a lot for helping to add 'Fixes' tag, Arnaldo.

Will note this for later patches.

Thanks,
Leo Yan