From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
xieyisheng1@huawei.com, alexey.budankov@linux.intel.com,
treeze.taeung@gmail.com, adrian.hunter@intel.com,
tmricht@linux.ibm.com, namhyung@kernel.org, irogers@google.com,
songliubraving@fb.com, yao.jin@linux.intel.com,
changbin.du@intel.com, leo.yan@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] perf annotate/config: More fixes
Date: Thu, 27 Feb 2020 14:16:48 +0100 [thread overview]
Message-ID: <20200227131648.GF34774@krava> (raw)
In-Reply-To: <20200227130846.GA9899@kernel.org>
On Thu, Feb 27, 2020 at 10:08:46AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Feb 16, 2020 at 10:15:49PM +0100, Jiri Olsa escreveu:
> > On Thu, Feb 13, 2020 at 12:12:58PM +0530, Ravi Bangoria wrote:
> > > These are the additional set of fixes on top of previous series:
> > > http://lore.kernel.org/r/20200204045233.474937-1-ravi.bangoria@linux.ibm.com
> > >
> > > Note for the last patch:
> > > I couldn't understand what intel-pt.cache-divisor is really used for.
> > > Adrian, can you please help.
> > >
> > > Ravi Bangoria (8):
> > > perf annotate/tui: Re-render title bar after switching back from
> > > script browser
> > > perf annotate: Fix --show-total-period for tui/stdio2
> > > perf annotate: Fix --show-nr-samples for tui/stdio2
> > > perf config: Introduce perf_config_u8()
> > > perf annotate: Make perf config effective
> > > perf annotate: Prefer cmdline option over default config
> > > perf annotate: Fix perf config option description
> > > perf config: Document missing config options
> >
> > nice, I guess this all worked in the past but got broken because
> > we don't have any tests for annotation code.. any chance you could
>
> I'm going thru them, can I take that "nice" as an Acked-by? Have you
> gone thru those patches?
nope, I just real fast checked on them.. I expected more discussion on tests ;-)
but as Ravi wrote, it could take some time
jirka
>
> - Arnaldo
>
> > think of some way to test annotations?
>
> > perhaps some shell script, or prepare all the needed data for annotation
> > manualy.. sort of like we did in tests/hists_*.c
> >
> > thanks,
> > jirka
> >
> > >
> > > tools/perf/Documentation/perf-config.txt | 74 +++++++++++++++++++-
> > > tools/perf/builtin-annotate.c | 4 +-
> > > tools/perf/builtin-report.c | 2 +-
> > > tools/perf/builtin-top.c | 2 +-
> > > tools/perf/ui/browsers/annotate.c | 19 +++--
> > > tools/perf/util/annotate.c | 89 +++++++++---------------
> > > tools/perf/util/annotate.h | 6 +-
> > > tools/perf/util/config.c | 12 ++++
> > > tools/perf/util/config.h | 1 +
> > > 9 files changed, 134 insertions(+), 75 deletions(-)
> > >
> > > --
> > > 2.24.1
> > >
> >
>
> --
>
> - Arnaldo
>
next prev parent reply other threads:[~2020-02-27 13:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 6:42 [PATCH 0/8] perf annotate/config: More fixes Ravi Bangoria
2020-02-13 6:42 ` [PATCH 1/8] perf annotate/tui: Re-render title bar after switching back from script browser Ravi Bangoria
2020-02-27 13:11 ` Arnaldo Carvalho de Melo
2020-02-29 9:16 ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-13 6:43 ` [PATCH 2/8] perf annotate: Fix --show-total-period for tui/stdio2 Ravi Bangoria
2020-02-27 13:14 ` Arnaldo Carvalho de Melo
2020-02-29 9:16 ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-13 6:43 ` [PATCH 3/8] perf annotate: Fix --show-nr-samples " Ravi Bangoria
2020-02-29 9:16 ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-13 6:43 ` [PATCH 4/8] perf config: Introduce perf_config_u8() Ravi Bangoria
2020-02-29 9:16 ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-13 6:43 ` [PATCH 5/8] perf annotate: Make perf config effective Ravi Bangoria
2020-02-27 13:32 ` Arnaldo Carvalho de Melo
2020-02-29 9:16 ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-13 6:43 ` [PATCH 6/8] perf annotate: Prefer cmdline option over default config Ravi Bangoria
2020-02-29 9:16 ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-13 6:43 ` [PATCH 7/8] perf annotate: Fix perf config option description Ravi Bangoria
2020-02-29 9:16 ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-13 6:43 ` [PATCH 8/8] perf config: Document missing config options Ravi Bangoria
2020-02-29 9:16 ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-16 21:15 ` [PATCH 0/8] perf annotate/config: More fixes Jiri Olsa
2020-02-17 13:02 ` Ravi Bangoria
2020-02-27 13:08 ` Arnaldo Carvalho de Melo
2020-02-27 13:16 ` Jiri Olsa [this message]
2020-02-27 13:43 ` Arnaldo Carvalho de Melo
2020-02-27 13:39 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227131648.GF34774@krava \
--to=jolsa@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=changbin.du@intel.com \
--cc=irogers@google.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=songliubraving@fb.com \
--cc=tmricht@linux.ibm.com \
--cc=treeze.taeung@gmail.com \
--cc=xieyisheng1@huawei.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.