Re: [PATCH 0/3] tool lib traceevent: Fix some parsing errors

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org,
	Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, Jaewon Kim <jaewon31.kim@samsung.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH 0/3] tool lib traceevent: Fix some parsing errors
Date: Thu, 18 Jun 2020 10:24:54 -0300	[thread overview]
Message-ID: <20200618132454.GA26403@kernel.org> (raw)
In-Reply-To: <656DB3D9-6D76-4103-B05B-8E4FE142C3B9@gmail.com>

Em Wed, Jun 17, 2020 at 07:55:29PM -0300, Arnaldo Carvalho de Melo escreveu:
> 
> 
> On June 17, 2020 6:28:04 PM GMT-03:00, Steven Rostedt <rostedt@goodmis.org> wrote:
> >Hi Arnaldo,
> >
> >I guess these patches were missed.
> 
> I'll pick those tomorrow,
> 
> Thanks for the reminder,

Thanks, applied to perf/urgent, for v5.8.

- Arnaldo

> 
> - Arnaldo
> 
> >
> >-- Steve
> >
> >
> >On Tue, 24 Mar 2020 16:08:45 -0400
> >Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> >> Arnaldo,
> >> 
> >> Here's a few patches for lib traceevent.
> >> 
> >> The first one adds an "append()" helper function for appending to
> >strings,
> >> which will also simplify the next patch.
> >> 
> >> The second patch handles "__attribute__((user))" in the field of a
> >> trace event. This is needed after the stack leak code added this
> >> to parameters of system call events.
> >> 
> >> The last patch adds handling of __builtin_expect(), as someone wanted
> >> to move IS_ERR_VALUE() from the fast path into the print fmt section,
> >> which breaks the parsing. This should also be useful for other macros
> >> that may evaluate down to a __builtin_expect().
> >> 
> >> Steven Rostedt (VMware) (3):
> >>       tools lib traceevent: Add append() function helper for
> >appending strings
> >>       tools lib traceevent: Handle __attribute__((user)) in field
> >names
> >>       tools lib traceevent: Add handler for __builtin_expect()
> >> 
> >> ----
> >>  tools/lib/traceevent/event-parse.c | 168
> >++++++++++++++++++++++++-------------
> >>  1 file changed, 111 insertions(+), 57 deletions(-)
> 
> -- 
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
> 

-- 

- Arnaldo