From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Jin Yao <yao.jin@linux.intel.com>,
John Garry <john.garry@huawei.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v2 00/10] perf parse-events: enable more flex/bison warnings
Date: Fri, 19 Jun 2020 08:50:11 -0300 [thread overview]
Message-ID: <20200619115011.GB12579@kernel.org> (raw)
In-Reply-To: <20200619043356.90024-1-irogers@google.com>
Em Thu, Jun 18, 2020 at 09:33:46PM -0700, Ian Rogers escreveu:
> All C compiler warnings are disabled are disabled by -w. This change
> removes the -w from flex and bison targets. To avoid implicit
> declarations header files are declared as targets and included.
>
> Tested with GCC 9.3.0 and clang 9.0.1.
>
> v2. predicates disabling the warnings on more recent bison and flex
> versions (3.5.3 and 2.6.4 respectively). An alternative would be
> to disabled a large number of warnings to cover the warnings
> generated in older distributions:
> flex_flags := -Wno-switch-enum -Wno-switch-default -Wno-unused-function \
> -Wno-redundant-decls -Wno-sign-compare -Wno-unused-parameter \
> -Wno-missing-prototypes -Wno-misleading-indentation
> bison_flags := -DYYENABLE_NLS=0 -Wno-unused-parameter -Wno-nested-externs \
> -Wno-implicit-function-declaration -Wno-switch-enum
>
> Previously posted as a single change:
> https://lore.kernel.org/lkml/20200609234344.3795-2-irogers@google.com/
So for the parts that you kept unchanged since Jiri acked it, please
next time collect that Acked-by, ok?
Going thru this now.
- Arnaldo
> Ian Rogers (10):
> perf parse-events: Use automatic variable for flex input
> perf parse-events: Use automatic variable for yacc input
> perf pmu: Add bison debug build flag
> perf pmu: Add flex debug build flag
> perf parse-events: Declare flex header file output
> perf parse-events: Declare bison header file output
> perf parse-events: Disable a subset of flex warnings
> perf expr: Avoid implicit lex function declaration
> perf parse-events: Avoid implicit lex function declaration
> perf parse-events: Disable a subset of bison warnings
>
> tools/perf/util/Build | 62 +++++++++++++++++++++++-----------
> tools/perf/util/expr.y | 2 ++
> tools/perf/util/parse-events.y | 1 +
> 3 files changed, 46 insertions(+), 19 deletions(-)
>
> --
> 2.27.0.111.gc72c7da667-goog
>
--
- Arnaldo
next prev parent reply other threads:[~2020-06-19 11:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 4:33 [PATCH v2 00/10] perf parse-events: enable more flex/bison warnings Ian Rogers
2020-06-19 4:33 ` [PATCH v2 01/10] perf parse-events: Use automatic variable for flex input Ian Rogers
2020-06-19 4:33 ` [PATCH v2 02/10] perf parse-events: Use automatic variable for yacc input Ian Rogers
2020-06-19 4:33 ` [PATCH v2 03/10] perf pmu: Add bison debug build flag Ian Rogers
2020-06-19 4:33 ` [PATCH v2 04/10] perf pmu: Add flex " Ian Rogers
2020-06-19 4:33 ` [PATCH v2 05/10] perf parse-events: Declare flex header file output Ian Rogers
2020-06-19 4:33 ` [PATCH v2 06/10] perf parse-events: Declare bison " Ian Rogers
2020-06-19 4:33 ` [PATCH v2 07/10] perf parse-events: Disable a subset of flex warnings Ian Rogers
2020-06-19 4:33 ` [PATCH v2 08/10] perf expr: Avoid implicit lex function declaration Ian Rogers
2020-06-19 4:33 ` [PATCH v2 09/10] perf parse-events: " Ian Rogers
2020-06-19 4:33 ` [PATCH v2 10/10] perf parse-events: Disable a subset of bison warnings Ian Rogers
2020-06-19 11:50 ` Arnaldo Carvalho de Melo [this message]
2020-06-19 12:15 ` [PATCH v2 00/10] perf parse-events: enable more flex/bison warnings Arnaldo Carvalho de Melo
2020-06-19 12:20 ` Arnaldo Carvalho de Melo
2020-06-19 15:15 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619115011.GB12579@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.