From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Kim Phillips <kim.phillips@amd.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Stephane Eranian <eranian@google.com>,
Alexey Budankov <alexey.budankov@linux.intel.com>,
Tony Jones <tonyj@suse.de>, Jin Yao <yao.jin@linux.intel.com>,
Ian Rogers <irogers@google.com>, "Paul A. Clarke" <pc@us.ibm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] perf record/stat: Explicitly call out event modifiers in the documentation
Date: Thu, 3 Sep 2020 16:01:01 -0300 [thread overview]
Message-ID: <20200903190101.GH3495158@kernel.org> (raw)
In-Reply-To: <20200901215853.276234-1-kim.phillips@amd.com>
Em Tue, Sep 01, 2020 at 04:58:53PM -0500, Kim Phillips escreveu:
> Event modifiers are not mentioned in the perf record or perf stat
> manpages. Add them to orient new users more effectively by pointing
> them to the perf list manpage for details.
Thanks, applied.
- Arnaldo
> Signed-off-by: Kim Phillips <kim.phillips@amd.com>
> Fixes: 2055fdaf8703 ("perf list: Document precise event sampling for AMD IBS")
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Stephane Eranian <eranian@google.com>
> Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
> Cc: Tony Jones <tonyj@suse.de>
> Cc: Jin Yao <yao.jin@linux.intel.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: "Paul A. Clarke" <pc@us.ibm.com>
> Cc: linux-perf-users@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: stable@vger.kernel.org
> ---
> tools/perf/Documentation/perf-record.txt | 4 ++++
> tools/perf/Documentation/perf-stat.txt | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
> index 3f72d8e261f3..bd50cdff08a8 100644
> --- a/tools/perf/Documentation/perf-record.txt
> +++ b/tools/perf/Documentation/perf-record.txt
> @@ -33,6 +33,10 @@ OPTIONS
> - a raw PMU event (eventsel+umask) in the form of rNNN where NNN is a
> hexadecimal event descriptor.
>
> + - a symbolic or raw PMU event followed by an optional colon
> + and a list of event modifiers, e.g., cpu-cycles:p. See the
> + linkperf:perf-list[1] man page for details on event modifiers.
> +
> - a symbolically formed PMU event like 'pmu/param1=0x3,param2/' where
> 'param1', 'param2', etc are defined as formats for the PMU in
> /sys/bus/event_source/devices/<pmu>/format/*.
> diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt
> index c9bfefc051fb..a4b1d11fefc8 100644
> --- a/tools/perf/Documentation/perf-stat.txt
> +++ b/tools/perf/Documentation/perf-stat.txt
> @@ -39,6 +39,10 @@ report::
> - a raw PMU event (eventsel+umask) in the form of rNNN where NNN is a
> hexadecimal event descriptor.
>
> + - a symbolic or raw PMU event followed by an optional colon
> + and a list of event modifiers, e.g., cpu-cycles:p. See the
> + linkperf:perf-list[1] man page for details on event modifiers.
> +
> - a symbolically formed event like 'pmu/param1=0x3,param2/' where
> param1 and param2 are defined as formats for the PMU in
> /sys/bus/event_source/devices/<pmu>/format/*
> --
> 2.27.0
>
--
- Arnaldo
prev parent reply other threads:[~2020-09-03 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 21:58 [PATCH] perf record/stat: Explicitly call out event modifiers in the documentation Kim Phillips
2020-09-03 19:01 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903190101.GH3495158@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tonyj@suse.de \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.