From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2] dm: Call proper helper to determine dax support
Date: Sat, 19 Sep 2020 02:38:12 +0800 [thread overview]
Message-ID: <202009190239.8hBPGV2C%lkp@intel.com> (raw)
In-Reply-To: <160040692945.25320.13233625491405115889.stgit@dwillia2-desk3.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 3660 bytes --]
Hi Dan,
I love your patch! Yet something to improve:
[auto build test ERROR on dm/for-next]
[also build test ERROR on linus/master v5.9-rc5 next-20200917]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Dan-Williams/dm-Call-proper-helper-to-determine-dax-support/20200918-135024
base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/dax/super.c:69:6: warning: no previous prototype for '__generic_fsdax_supported' [-Wmissing-prototypes]
69 | bool __generic_fsdax_supported(struct dax_device *dax_dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/dax/super.c:167:6: warning: no previous prototype for '__bdev_dax_supported' [-Wmissing-prototypes]
167 | bool __bdev_dax_supported(struct block_device *bdev, int blocksize)
| ^~~~~~~~~~~~~~~~~~~~
>> drivers/dax/super.c:325:6: error: redefinition of 'dax_supported'
325 | bool dax_supported(struct dax_device *dax_dev, struct block_device *bdev,
| ^~~~~~~~~~~~~
In file included from drivers/dax/super.c:16:
include/linux/dax.h:162:20: note: previous definition of 'dax_supported' was here
162 | static inline bool dax_supported(struct dax_device *dax_dev,
| ^~~~~~~~~~~~~
drivers/dax/super.c:451:6: warning: no previous prototype for 'run_dax' [-Wmissing-prototypes]
451 | void run_dax(struct dax_device *dax_dev)
| ^~~~~~~
# https://github.com/0day-ci/linux/commit/36000760ad7496d92b34294192ae5dd7da0eeb27
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dan-Williams/dm-Call-proper-helper-to-determine-dax-support/20200918-135024
git checkout 36000760ad7496d92b34294192ae5dd7da0eeb27
vim +/dax_supported +325 drivers/dax/super.c
b0686260fecaa92 Dan Williams 2017-01-26 324
7bf7eac8d648057 Dan Williams 2019-05-16 @325 bool dax_supported(struct dax_device *dax_dev, struct block_device *bdev,
7bf7eac8d648057 Dan Williams 2019-05-16 326 int blocksize, sector_t start, sector_t len)
7bf7eac8d648057 Dan Williams 2019-05-16 327 {
36000760ad7496d Jan Kara 2020-09-17 328 if (!dax_dev)
36000760ad7496d Jan Kara 2020-09-17 329 return false;
36000760ad7496d Jan Kara 2020-09-17 330
7bf7eac8d648057 Dan Williams 2019-05-16 331 if (!dax_alive(dax_dev))
7bf7eac8d648057 Dan Williams 2019-05-16 332 return false;
7bf7eac8d648057 Dan Williams 2019-05-16 333
7bf7eac8d648057 Dan Williams 2019-05-16 334 return dax_dev->ops->dax_supported(dax_dev, bdev, blocksize, start, len);
7bf7eac8d648057 Dan Williams 2019-05-16 335 }
36000760ad7496d Jan Kara 2020-09-17 336 EXPORT_SYMBOL_GPL(dax_supported);
7bf7eac8d648057 Dan Williams 2019-05-16 337
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 67646 bytes --]
next prev parent reply other threads:[~2020-09-18 18:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 5:30 [PATCH v2] dm: Call proper helper to determine dax support Dan Williams
2020-09-18 5:30 ` Dan Williams
2020-09-18 5:30 ` Dan Williams
2020-09-18 8:52 ` kernel test robot
2020-09-18 15:30 ` [dm-devel] " Darrick J. Wong
2020-09-18 15:30 ` Darrick J. Wong
2020-09-18 16:54 ` Dan Williams
2020-09-18 16:54 ` Dan Williams
2020-09-18 18:38 ` kernel test robot [this message]
2020-09-21 5:53 ` Naresh Kamboju
2020-09-21 5:53 ` Naresh Kamboju
2020-09-21 9:58 ` Jan Kara
2020-09-21 9:58 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009190239.8hBPGV2C%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.