From: Mark Brown <broonie@kernel.org>
To: Dave Ertman <david.m.ertman@intel.com>
Cc: alsa-devel@alsa-project.org, Kiran Patil <kiran.patil@intel.com>,
tiwai@suse.de, gregkh@linuxfoundation.org,
ranjani.sridharan@intel.com,
pierre-louis.bossart@linux.intel.com,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Fred Oh <fred.oh@linux.intel.com>,
parav@nvidia.com, jgg@nvidia.com,
Dan Williams <dan.j.williams@intel.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Parav Pandit <parav@mellanox.com>
Subject: Re: [PATCH 1/6] Add ancillary bus support
Date: Thu, 1 Oct 2020 14:27:09 +0100 [thread overview]
Message-ID: <20201001132709.GG6715@sirena.org.uk> (raw)
In-Reply-To: <20200930225051.889607-2-david.m.ertman@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]
On Wed, Sep 30, 2020 at 03:50:46PM -0700, Dave Ertman wrote:
> Documentation/driver-api/ancillary_bus.rst | 230 +++++++++++++++++++++
> Documentation/driver-api/index.rst | 1 +
It would probably be useful to have the documentation in a separate
patch, it's a huge proportion of the patch and would make it much more
approachable.
> +are controlled by DT/ACPI. The same argument applies for not using MFD in this
> +scenario as MFD relies on individual function devices being physical devices
> +that are DT enumerated.
See my commments on the cover letter about MFD, this is just not true.
> +An example for this kind of requirement is the audio subsystem where a single
> +IP is handling multiple entities such as HDMI, Soundwire, local devices such as
> +mics/speakers etc. The split for the core's functionality can be arbitrary or
This is not a requirement of the audio subsystem, this is to do with how
the Intel audio hardware has been implemented on their modern SoCs.
> +int ancillary_device_initialize(struct ancillary_device *ancildev)
> +{
> +int __ancillary_device_add(struct ancillary_device *ancildev, const char *modname)
> +{
It can be useful to have this split but there's also going to be plenty
of cases where people just need to register a device based on the struct
ancilliary_device straight away so it would be good to at least have a
standard ancilliary_device_new() (or whatever) that does both steps in
one. As Greg said in his review this split model is a bit more fiddly
to use and frequently leads to error handling problems in drivers.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-10-01 13:30 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 22:50 [PATCH 0/6] Ancillary bus implementation and SOF multi-client support Dave Ertman
2020-09-30 22:50 ` [PATCH 1/6] Add ancillary bus support Dave Ertman
2020-09-30 23:05 ` Jason Gunthorpe
2020-10-01 11:01 ` Greg KH
2020-10-01 11:46 ` Jason Gunthorpe
2020-10-01 11:54 ` Greg KH
2020-10-01 12:02 ` Jason Gunthorpe
2020-10-01 12:15 ` Greg KH
2020-10-01 18:26 ` Ertman, David M
2020-10-01 11:02 ` Greg KH
2020-10-01 16:30 ` Ertman, David M
2020-10-01 11:05 ` Greg KH
2020-10-01 11:58 ` Jason Gunthorpe
2020-10-01 12:14 ` Greg KH
2020-10-01 14:33 ` Jason Gunthorpe
2020-10-01 14:38 ` Greg KH
2020-10-01 16:06 ` Pierre-Louis Bossart
2020-10-01 17:42 ` Jason Gunthorpe
2020-10-01 14:39 ` Parav Pandit
2020-10-01 14:43 ` Greg KH
2020-10-01 13:27 ` Mark Brown [this message]
2020-09-30 22:50 ` [PATCH 2/6] ASoC: SOF: Introduce descriptors for SOF client Dave Ertman
2020-10-01 13:02 ` Greg KH
2020-10-01 15:59 ` Sridharan, Ranjani
2020-10-01 22:16 ` Sridharan, Ranjani
2020-10-02 4:53 ` gregkh
2020-10-02 17:07 ` Sridharan, Ranjani
2020-10-03 9:02 ` gregkh
2020-10-05 2:35 ` Sridharan, Ranjani
2020-10-05 11:27 ` gregkh
2020-10-05 15:18 ` Pierre-Louis Bossart
2020-10-05 15:32 ` gregkh
2020-10-01 13:38 ` Mark Brown
2020-10-01 16:48 ` Sridharan, Ranjani
2020-09-30 22:50 ` [PATCH 3/6] ASoC: SOF: Create client driver for IPC test Dave Ertman
2020-10-01 13:04 ` Greg KH
2020-10-01 16:46 ` Sridharan, Ranjani
2020-10-01 13:09 ` Greg KH
2020-10-01 13:55 ` Pierre-Louis Bossart
2020-10-01 16:48 ` Ertman, David M
2020-10-01 13:59 ` Mark Brown
2020-09-30 22:50 ` [PATCH 4/6] ASoC: SOF: ops: Add ops for client registration Dave Ertman
2020-09-30 22:50 ` [PATCH 5/6] ASoC: SOF: Intel: Define " Dave Ertman
2020-09-30 22:50 ` [PATCH 6/6] ASoC: SOF: debug: Remove IPC flood test support in SOF core Dave Ertman
2020-10-01 5:58 ` [PATCH 0/6] Ancillary bus implementation and SOF multi-client support Greg KH
2020-10-01 15:54 ` Ertman, David M
2020-10-01 7:14 ` Greg KH
2020-10-01 15:55 ` Ertman, David M
2020-10-01 16:10 ` Greg KH
2020-10-01 17:13 ` Ertman, David M
2020-10-02 20:23 ` Ertman, David M
2020-10-03 9:08 ` Greg KH
2020-10-03 9:09 ` Greg KH
2020-10-04 2:26 ` Parav Pandit
2020-10-04 23:45 ` Williams, Dan J
2020-10-05 1:18 ` Ertman, David M
2020-10-05 2:39 ` Parav Pandit
2020-10-05 11:25 ` gregkh
2020-10-06 22:40 ` Dan Williams
2020-10-07 9:14 ` gregkh
2020-10-07 16:19 ` Dan Williams
2020-10-07 16:22 ` Mark Brown
2020-10-07 16:41 ` Dan Williams
2020-10-07 16:42 ` Pierre-Louis Bossart
2020-10-07 16:56 ` Parav Pandit
2020-10-01 10:05 ` Rojewski, Cezary
2020-10-01 10:59 ` gregkh
2020-10-01 12:49 ` Jason Gunthorpe
2020-10-01 12:55 ` gregkh
2020-10-01 13:26 ` Jason Gunthorpe
2020-10-01 14:17 ` gregkh
2020-10-01 15:08 ` Parav Pandit
2020-10-01 12:50 ` Mark Brown
2020-10-01 13:12 ` Greg KH
2020-10-01 13:42 ` Jason Gunthorpe
2020-10-01 14:40 ` Mark Brown
2020-10-01 15:32 ` Greg KH
2020-10-01 16:03 ` Mark Brown
2020-10-01 18:16 ` Greg KH
2020-10-01 18:29 ` Ertman, David M
2020-10-01 19:38 ` Mark Brown
2020-10-01 19:54 ` Ertman, David M
2020-10-01 20:17 ` Mark Brown
2020-10-02 0:47 ` Jason Gunthorpe
2020-10-02 11:19 ` Mark Brown
2020-10-02 17:23 ` Ertman, David M
2020-10-02 17:25 ` Jason Gunthorpe
2020-10-02 17:44 ` Mark Brown
2020-10-01 14:07 ` Pierre-Louis Bossart
2020-10-01 15:24 ` Mark Brown
2020-10-01 16:20 ` Pierre-Louis Bossart
2020-10-01 16:51 ` Mark Brown
2020-10-01 18:04 ` Jason Gunthorpe
2020-10-01 18:13 ` Greg KH
2020-10-01 19:23 ` Mark Brown
2020-10-01 16:50 ` Ertman, David M
2020-10-01 17:10 ` Mark Brown
2020-10-01 17:16 ` Ertman, David M
2020-10-01 17:52 ` Ertman, David M
2020-10-01 5:05 Dave Ertman
2020-10-01 5:05 ` [PATCH 1/6] Add ancillary bus support Dave Ertman
2020-10-01 8:32 ` Leon Romanovsky
2020-10-01 17:20 ` Ertman, David M
2020-10-01 17:40 ` Leon Romanovsky
2020-10-01 18:29 ` Parav Pandit
2020-10-01 19:32 ` Leon Romanovsky
2020-10-02 5:29 ` Parav Pandit
2020-10-02 6:20 ` Leon Romanovsky
2020-10-02 8:42 ` Parav Pandit
2020-10-02 11:13 ` Leon Romanovsky
2020-10-02 11:27 ` Parav Pandit
2020-10-02 11:45 ` Leon Romanovsky
2020-10-02 11:56 ` Parav Pandit
2020-10-01 5:08 [PATCH 0/6] Ancillary bus implementation and SOF multi-client support Dave Ertman
2020-10-01 5:08 ` [PATCH 1/6] Add ancillary bus support Dave Ertman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001132709.GG6715@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dan.j.williams@intel.com \
--cc=david.m.ertman@intel.com \
--cc=fred.oh@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@nvidia.com \
--cc=kiran.patil@intel.com \
--cc=parav@mellanox.com \
--cc=parav@nvidia.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=shiraz.saleem@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.