From: kernel test robot <lkp@intel.com> To: Perry Yuan <Perry.Yuan@dell.com>, hdegoede@redhat.com, mgross@linux.intel.com, mjg59@srcf.ucam.org, pali@kernel.org Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, perry_yuan <Perry.Yuan@dell.com>, Limonciello Mario <Mario.Limonciello@dell.com> Subject: Re: [PATCH] platform/x86: dell-privacy: Add support for new privacy driver Date: Wed, 4 Nov 2020 00:50:17 +0800 [thread overview] Message-ID: <202011040057.3zbm67aA-lkp@intel.com> (raw) In-Reply-To: <20201103125542.8572-1-Perry_Yuan@Dell.com> [-- Attachment #1: Type: text/plain, Size: 2572 bytes --] Hi Perry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10-rc2] [cannot apply to next-20201103] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Perry-Yuan/platform-x86-dell-privacy-Add-support-for-new-privacy-driver/20201103-205721 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b7cbaf59f62f8ab8f157698f9e31642bff525bd0 config: i386-randconfig-r024-20201103 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/cee9f60d7ca58d8f0c6b113c5f7af2dec7e2e27d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Perry-Yuan/platform-x86-dell-privacy-Add-support-for-new-privacy-driver/20201103-205721 git checkout cee9f60d7ca58d8f0c6b113c5f7af2dec7e2e27d # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/platform/x86/dell-laptop.c: In function 'dell_exit': >> drivers/platform/x86/dell-laptop.c:2289:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 2289 | if (!privacy_valid) | ^~ drivers/platform/x86/dell-laptop.c:2291:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 2291 | dell_cleanup_rfkill(); | ^~~~~~~~~~~~~~~~~~~ vim +/if +2289 drivers/platform/x86/dell-laptop.c 2280 2281 static void __exit dell_exit(void) 2282 { 2283 dell_laptop_unregister_notifier(&dell_laptop_notifier); 2284 debugfs_remove_recursive(dell_laptop_dir); 2285 if (quirks && quirks->touchpad_led) 2286 touchpad_led_exit(); 2287 kbd_led_exit(); 2288 backlight_device_unregister(dell_backlight_device); > 2289 if (!privacy_valid) 2290 led_classdev_unregister(&micmute_led_cdev); 2291 dell_cleanup_rfkill(); 2292 if (platform_device) { 2293 platform_device_unregister(platform_device); 2294 platform_driver_unregister(&platform_driver); 2295 } 2296 } 2297 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 32712 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH] platform/x86: dell-privacy: Add support for new privacy driver Date: Wed, 04 Nov 2020 00:50:17 +0800 [thread overview] Message-ID: <202011040057.3zbm67aA-lkp@intel.com> (raw) In-Reply-To: <20201103125542.8572-1-Perry_Yuan@Dell.com> [-- Attachment #1: Type: text/plain, Size: 2634 bytes --] Hi Perry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10-rc2] [cannot apply to next-20201103] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Perry-Yuan/platform-x86-dell-privacy-Add-support-for-new-privacy-driver/20201103-205721 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b7cbaf59f62f8ab8f157698f9e31642bff525bd0 config: i386-randconfig-r024-20201103 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/cee9f60d7ca58d8f0c6b113c5f7af2dec7e2e27d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Perry-Yuan/platform-x86-dell-privacy-Add-support-for-new-privacy-driver/20201103-205721 git checkout cee9f60d7ca58d8f0c6b113c5f7af2dec7e2e27d # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/platform/x86/dell-laptop.c: In function 'dell_exit': >> drivers/platform/x86/dell-laptop.c:2289:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 2289 | if (!privacy_valid) | ^~ drivers/platform/x86/dell-laptop.c:2291:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 2291 | dell_cleanup_rfkill(); | ^~~~~~~~~~~~~~~~~~~ vim +/if +2289 drivers/platform/x86/dell-laptop.c 2280 2281 static void __exit dell_exit(void) 2282 { 2283 dell_laptop_unregister_notifier(&dell_laptop_notifier); 2284 debugfs_remove_recursive(dell_laptop_dir); 2285 if (quirks && quirks->touchpad_led) 2286 touchpad_led_exit(); 2287 kbd_led_exit(); 2288 backlight_device_unregister(dell_backlight_device); > 2289 if (!privacy_valid) 2290 led_classdev_unregister(&micmute_led_cdev); 2291 dell_cleanup_rfkill(); 2292 if (platform_device) { 2293 platform_device_unregister(platform_device); 2294 platform_driver_unregister(&platform_driver); 2295 } 2296 } 2297 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 32712 bytes --]
next prev parent reply other threads:[~2020-11-03 16:50 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-03 12:55 [PATCH] platform/x86: dell-privacy: Add support for new privacy driver Perry Yuan 2020-11-03 16:22 ` kernel test robot 2020-11-03 16:22 ` kernel test robot 2020-11-03 16:50 ` kernel test robot [this message] 2020-11-03 16:50 ` kernel test robot 2020-11-03 19:14 ` Barnabás Pőcze 2020-11-04 1:49 ` Matthew Garrett 2020-11-11 7:21 ` Yuan, Perry 2020-11-11 7:24 ` Matthew Garrett 2020-11-11 14:30 ` Limonciello, Mario 2020-11-12 15:06 ` Enrico Weigelt, metux IT consult 2020-11-12 15:31 ` Limonciello, Mario 2020-11-12 15:55 ` Hans de Goede 2020-11-12 15:57 ` Limonciello, Mario 2020-11-04 6:43 ` kernel test robot 2020-11-04 6:43 ` kernel test robot 2020-11-09 11:16 ` Hans de Goede 2020-11-11 7:24 ` Yuan, Perry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202011040057.3zbm67aA-lkp@intel.com \ --to=lkp@intel.com \ --cc=Mario.Limonciello@dell.com \ --cc=Perry.Yuan@dell.com \ --cc=hdegoede@redhat.com \ --cc=kbuild-all@lists.01.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mgross@linux.intel.com \ --cc=mjg59@srcf.ucam.org \ --cc=pali@kernel.org \ --cc=platform-driver-x86@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.