Re: [PATCH] perf record: Tweak "Lowering..." warning in record_opts__config_freq

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Hans-Peter Nilsson <hp@axis.com>
Cc: linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Ian Rogers <irogers@google.com>
Subject: Re: [PATCH] perf record: Tweak "Lowering..." warning in record_opts__config_freq
Date: Mon, 28 Dec 2020 12:25:32 -0300	[thread overview]
Message-ID: <20201228152532.GE521329@kernel.org> (raw)
In-Reply-To: <20201228031908.B049B203B5@pchp3.se.axis.com>

Em Mon, Dec 28, 2020 at 04:19:08AM +0100, Hans-Peter Nilsson escreveu:
> That is, instead of "Lowering default frequency rate to <F>" say
> "Lowering default frequency rate from <f> to <F>", specifying
> the overridden default frequency <f>, so you don't have to grep
> through the source to "remember" that was e.g. 4000.

Thanks, applied.

- Arnaldo

> Signed-off-by: Hans-Peter Nilsson <hp@axis.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Kan Liang <kan.liang@linux.intel.com>
> Cc: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/util/record.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/record.c b/tools/perf/util/record.c
> index 07e4b96a6625..3b38e7be10da 100644
> --- a/tools/perf/util/record.c
> +++ b/tools/perf/util/record.c
> @@ -202,10 +202,10 @@ static int record_opts__config_freq(struct record_opts *opts)
>  	 * Default frequency is over current maximum.
>  	 */
>  	if (max_rate < opts->freq) {
> -		pr_warning("Lowering default frequency rate to %u.\n"
> +		pr_warning("Lowering default frequency rate from %u to %u.\n"
>  			   "Please consider tweaking "
>  			   "/proc/sys/kernel/perf_event_max_sample_rate.\n",
> -			   max_rate);
> +			   opts->freq, max_rate);
>  		opts->freq = max_rate;
>  	}
>  
> -- 
> 2.11.0
> 
> brgds, H-P

-- 

- Arnaldo