From: Jan Kara <jack@suse.cz>
To: Ted Tso <tytso@mit.edu>
Cc: <linux-ext4@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
Jan Kara <jack@suse.cz>
Subject: [PATCH v3 08/12] ext4: Switch to using ext4_do_writepages() for ordered data writeout
Date: Mon, 5 Dec 2022 13:29:22 +0100 [thread overview]
Message-ID: <20221205122928.21959-8-jack@suse.cz> (raw)
In-Reply-To: <20221205122604.25994-1-jack@suse.cz>
Use the standard writepages method (ext4_do_writepages()) to perform
writeout of ordered data during journal commit.
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/ext4/ext4.h | 1 +
fs/ext4/inode.c | 16 ++++++++++++++++
fs/ext4/super.c | 3 +--
3 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 1b3bffc04fd0..07b55cc48578 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -2999,6 +2999,7 @@ extern void ext4_set_inode_flags(struct inode *, bool init);
extern int ext4_alloc_da_blocks(struct inode *inode);
extern void ext4_set_aops(struct inode *inode);
extern int ext4_writepage_trans_blocks(struct inode *);
+extern int ext4_normal_submit_inode_data_buffers(struct jbd2_inode *jinode);
extern int ext4_chunk_trans_blocks(struct inode *, int nrblocks);
extern int ext4_zero_partial_blocks(handle_t *handle, struct inode *inode,
loff_t lstart, loff_t lend);
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 4f8f4959524c..b93a436bf5bc 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2953,6 +2953,22 @@ static int ext4_writepages(struct address_space *mapping,
return ret;
}
+int ext4_normal_submit_inode_data_buffers(struct jbd2_inode *jinode)
+{
+ struct writeback_control wbc = {
+ .sync_mode = WB_SYNC_ALL,
+ .nr_to_write = LONG_MAX,
+ .range_start = jinode->i_dirty_start,
+ .range_end = jinode->i_dirty_end,
+ };
+ struct mpage_da_data mpd = {
+ .inode = jinode->i_vfs_inode,
+ .wbc = &wbc,
+ .can_map = 0,
+ };
+ return ext4_do_writepages(&mpd);
+}
+
static int ext4_dax_writepages(struct address_space *mapping,
struct writeback_control *wbc)
{
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 7cdd2138c897..c02329dd7574 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -540,8 +540,7 @@ static int ext4_journal_submit_inode_data_buffers(struct jbd2_inode *jinode)
if (ext4_should_journal_data(jinode->i_vfs_inode))
ret = ext4_journalled_submit_inode_data_buffers(jinode);
else
- ret = jbd2_journal_submit_inode_data_buffers(jinode);
-
+ ret = ext4_normal_submit_inode_data_buffers(jinode);
return ret;
}
--
2.35.3
next prev parent reply other threads:[~2022-12-05 12:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 12:29 [PATCH v3 0/12] ext4: Stop using ext4_writepage() for writeout of ordered data Jan Kara
2022-12-05 12:29 ` [PATCH v3 01/12] ext4: Handle redirtying in ext4_bio_write_page() Jan Kara
2022-12-05 12:29 ` [PATCH v3 02/12] ext4: Move keep_towrite handling to ext4_bio_write_page() Jan Kara
2022-12-05 12:29 ` [PATCH v3 03/12] ext4: Remove nr_submitted from ext4_bio_write_page() Jan Kara
2022-12-05 12:29 ` [PATCH v3 04/12] ext4: Drop pointless IO submission " Jan Kara
2022-12-05 12:29 ` [PATCH v3 05/12] ext4: Add support for writepages calls that cannot map blocks Jan Kara
2022-12-05 12:29 ` [PATCH v3 06/12] ext4: Provide ext4_do_writepages() Jan Kara
2022-12-05 12:29 ` [PATCH v3 07/12] ext4: Move percpu_rwsem protection into ext4_writepages() Jan Kara
2022-12-05 12:29 ` Jan Kara [this message]
2022-12-05 12:29 ` [PATCH v3 09/12] jbd2: Switch jbd2_submit_inode_data() to use fs-provided hook for data writeout Jan Kara
2022-12-05 12:29 ` [PATCH v3 10/12] ext4: Switch to using write_cache_pages() for data=journal writeout Jan Kara
2022-12-05 12:29 ` [PATCH v3 11/12] ext4: Stop providing .writepage hook Jan Kara
2022-12-05 18:32 ` kernel test robot
2022-12-06 3:17 ` Theodore Ts'o
2022-12-06 10:52 ` Jan Kara
2022-12-07 7:38 ` Christoph Hellwig
2022-12-07 11:17 ` Jan Kara
2022-12-05 12:29 ` [PATCH v3 12/12] ext4: Remove ordered data support from ext4_writepage() Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205122928.21959-8-jack@suse.cz \
--to=jack@suse.cz \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.