Re: [PATCH] perf list: Hide deprecated events by default

From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com,
	Linux-kernel@vger.kernel.org, ak@linux.intel.com,
	kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf list: Hide deprecated events by default
Date: Wed, 16 Oct 2019 08:59:13 +0800	[thread overview]
Message-ID: <627305a7-3aec-037a-1c36-6ca884f35d1d@linux.intel.com> (raw)
In-Reply-To: <20191015091401.GE10951@krava>

On 10/15/2019 5:14 PM, Jiri Olsa wrote:
> On Tue, Oct 15, 2019 at 10:53:57AM +0800, Jin Yao wrote:
>> There are some deprecated events listed by perf list. But we can't remove
>> them from perf list with ease because some old scripts may use them.
>>
>> Deprecated events are old names of renamed events.  When an event gets
>> renamed the old name is kept around for some time and marked with
>> Deprecated. The newer Intel event lists in the tree already have these
>> headers.
>>
>> So we need to keep them in the event list, but provide a new option to
>> show them. The new option is "--deprecated".
>>
>> With this patch, the deprecated events are hidden by default but they can
>> be displayed when option "--deprecated" is enabled.
> 
> not sure it's wise to hide them, because people will not read man page
> to find --deprecated option, they will rather complain right away ;-)
> 
> how about to display them as another topic, like:
> 
> pipeline:
> 	...
> uncore:
> 	...
> deprecated:
> 	...
> 
> jirka
> 

Hi Jiri,

I don't know if we add a new topic "deprecated" in perf list output, 
does the old script need to be modified as well?

Say the events are moved to the "deprecated" section, I just guess the 
script needs the modification.

That's just my personal guess. :)

Thanks
Jin Yao