From: Dan Williams <dan.j.williams@intel.com>
To: Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
<linux-coco@lists.linux.dev>
Cc: Dionna Amalie Glaze <dionnaglaze@google.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Peter Gonda <pgonda@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Samuel Ortiz <sameo@rivosinc.com>,
Thomas Gleixner <tglx@linutronix.de>, <peterz@infradead.org>,
<linux-kernel@vger.kernel.org>, <x86@kernel.org>,
<dave.hansen@linux.intel.com>
Subject: Re: [PATCH v4 2/6] configfs-tsm: Introduce a shared ABI for attestation reports
Date: Tue, 26 Sep 2023 20:17:29 -0700 [thread overview]
Message-ID: <65139ec9e25ef_91c1e294aa@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <668e7778-e1f6-48a8-9631-0643c1ce9e4f@linux.intel.com>
Kuppuswamy Sathyanarayanan wrote:
[..]
> >>> +/**
> >>> + * struct tsm_desc - option descriptor for generating tsm report blobs
> >>> + * @privlevel: optional privilege level to associate with @outblob
> >>> + * @inblob_len: sizeof @inblob
> >>> + * @inblob: arbitrary input data
> >>> + */
> >>> +struct tsm_desc {
> >>> + unsigned int privlevel;
> >>> + size_t inblob_len;
> >>> + u8 inblob[TSM_INBLOB_MAX];
> >>> +};
> >>> +
> >>> +/**
> >>> + * struct tsm_report - track state of report generation relative to options
> >>> + * @desc: report generation options / cached report state
> >>> + * @outblob: generated evidence to provider to the attestation agent
> >>> + * @outblob_len: sizeof(outblob)
> >>
> >> I think following is incorrect. You might want to add info about certs_len
> >> and certs.
> >
> > Yeah, missed updating this with certs addition. The outblob_len
> > definition is correct, or do you mean the kdoc is out of order with
> > respect to the struct?
>
> No, I am talking about the write_generation, read_generation and cfg options.
> They are part of struct tsm_report_state, so why document it here?
Ah yup, will fix.
next prev parent reply other threads:[~2023-09-27 3:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 4:16 [PATCH v4 0/6] configfs-tsm: Attestation Report ABI Dan Williams
2023-09-26 4:17 ` [PATCH v4 1/6] virt: coco: Add a coco/Makefile and coco/Kconfig Dan Williams
2023-09-26 4:17 ` [PATCH v4 2/6] configfs-tsm: Introduce a shared ABI for attestation reports Dan Williams
2023-09-26 18:49 ` Kuppuswamy Sathyanarayanan
2023-09-26 18:59 ` Dan Williams
2023-09-27 0:43 ` Kuppuswamy Sathyanarayanan
2023-09-27 3:17 ` Dan Williams [this message]
2023-09-27 8:04 ` Thomas Fossati
2023-09-27 8:21 ` Dan Williams
2023-09-27 8:25 ` Thomas Fossati
2023-09-27 14:38 ` Peter Gonda
2023-09-27 19:05 ` Thomas Fossati
2023-09-27 8:43 ` Thomas Fossati
2023-09-27 2:10 ` Kuppuswamy Sathyanarayanan
2023-09-26 4:17 ` [PATCH v4 3/6] virt: sevguest: Prep for kernel internal {get, get_ext}_report() Dan Williams
2023-09-26 18:51 ` Kuppuswamy Sathyanarayanan
2023-09-26 4:17 ` [PATCH v4 4/6] mm/slab: Add __free() support for kvfree Dan Williams
2023-09-26 4:17 ` [PATCH v4 5/6] virt: sevguest: Add TSM_REPORTS support for SNP_{GET, GET_EXT}_REPORT Dan Williams
2023-10-04 8:22 ` Dan Carpenter
2023-09-26 4:17 ` [PATCH v4 6/6] virt: tdx-guest: Add Quote generation support using TSM_REPORTS Dan Williams
2023-09-27 16:14 ` Peter Gonda
2023-09-27 16:53 ` Dan Williams
2023-09-28 22:49 ` Dan Williams
2023-09-29 17:26 ` Peter Gonda
2023-10-03 18:37 ` Peter Gonda
2023-10-03 19:29 ` Kuppuswamy Sathyanarayanan
2023-10-03 20:06 ` Peter Gonda
2023-10-04 0:54 ` Dan Williams
2023-10-10 19:36 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65139ec9e25ef_91c1e294aa@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dave.hansen@linux.intel.com \
--cc=dionnaglaze@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pgonda@google.com \
--cc=sameo@rivosinc.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.