From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [RFC] drm/i915/backlight: switch to unique backlight device names
Date: Wed, 28 Apr 2021 13:16:04 +0300 [thread overview]
Message-ID: <87zgxi3eaj.fsf@intel.com> (raw)
In-Reply-To: <YG4aSL1jEG/Tz7wU@intel.com>
On Wed, 07 Apr 2021, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Apr 07, 2021 at 12:08:12PM +0300, Jani Nikula wrote:
>> Change the backlight device names from intel_backlight to
>> card%d-%s-backlight format, for example card0-eDP-1-backlight, to make
>> them unique. Otherwise, registering multiple backlight devices with
>> intel_backlight name will fail, regardless of whether they're two
>> connectors in the same device or two different devices.
>>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2794
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> ---
>>
>> Is the name "intel_backlight" part of the UABI? In theory the userspace
>> should only look at the names and types available under
>> /sys/class/backlight, not the exact names.
>
> Quick glance at some things suggest this might affect some
> custom setups people have.
>
> There is an xorg.conf option in the intel ddx to force the
> backlight device selection. But I didn't see any hardcoding
> of the backlight device name, so unless the user has
> configured that knob things should keep working I think.
>
> Also googling says systemd might have some backlight
> name to service name magic going on. But I was too lazy
> to actually read the code so don't know the details.
Thanks, I switched to using intel_backlight first, and falling back to
unique names after that [1].
BR,
Jani.
[1] https://patchwork.freedesktop.org/series/89578/
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-04-28 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 9:08 [Intel-gfx] [RFC] drm/i915/backlight: switch to unique backlight device names Jani Nikula
2021-04-07 9:25 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2021-04-07 9:49 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-04-07 10:02 ` Jani Nikula
2021-04-07 20:47 ` [Intel-gfx] [RFC] " Ville Syrjälä
2021-04-28 10:16 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgxi3eaj.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.