All of lore.kernel.org
 help / color / mirror / Atom feed
From: Teng Long <dyroneteng@gmail.com>
To: jonathantanmy@google.com
Cc: dyroneteng@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] Optimize the description of the configuration in packfile-uris doc
Date: Thu, 13 May 2021 10:45:24 +0800	[thread overview]
Message-ID: <CADMgQSQyn7MvzqYSbou=N3ArYATtr7JP=sqS1PNS1Tr0sO2s8Q@mail.gmail.com> (raw)

Jonathan Tan <jonathantanmy@google.com> writes:

>As for the commit message, limit the title to 50 characters or fewer if
>possible. Maybe something like "packfile-uri.txt: fix blobPackfileUri
>description" or something like that.

Thanks for mention this, "packfile-uri.txt: fix blobPackfileUri
description" is good and meets the "50 characters" requirement.

So, you are right and the title will be changed in the next patch.

>Also in the commit message, maybe mention that the correct format can be
>seen in t5702.

Because I am implementing another patch[1] about supporting the commit
object in packfile-uri, so I noticed the `configure_exclusion` function in
t5702.

Agree and will include it in the next patch.

Thanks.

[1] https://public-inbox.org/git/20210507021140.31372-1-dyroneteng@gmail.com

             reply	other threads:[~2021-05-13  2:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-13  2:45 Teng Long [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-05-06  7:33 [PATCH] Optimize the description of the configuration in packfile-uris doc Teng Long
2021-05-06 16:47 ` Jonathan Tan
2021-05-06 21:39   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADMgQSQyn7MvzqYSbou=N3ArYATtr7JP=sqS1PNS1Tr0sO2s8Q@mail.gmail.com' \
    --to=dyroneteng@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.