Re: [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups

From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Andi Kleen <ak@linux.intel.com>, Ian Rogers <irogers@google.com>,
	John Garry <john.garry@huawei.com>,
	Kajol Jain <kjain@linux.ibm.com>,
	kernel test robot <rong.a.chen@intel.com>
Subject: Re: [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups
Date: Fri, 25 Sep 2020 22:44:53 +0900	[thread overview]
Message-ID: <CAM9d7cgHBe6-SfCc3RTfLmrvaKr1hSprmJPd2BFnQtMUu_6TFw@mail.gmail.com> (raw)
In-Reply-To: <20200925132636.GB3273770@krava>

On Fri, Sep 25, 2020 at 10:26 PM Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Thu, Sep 24, 2020 at 09:44:53PM +0900, Namhyung Kim wrote:
>
> SNIP
>
> >
> > +     if (metric_events) {
> > +             orig_metric_events = *metric_events;
> > +             rblist__init(metric_events);
> > +     } else {
> > +             rblist__init(&orig_metric_events);
> > +     }
> > +
> >       for (;;) {
> >               p = strchr(str, ',');
> >               e = p ? p : eos;
> > @@ -255,6 +267,14 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str)
> >               cgroup__put(cgrp);
> >               nr_cgroups++;
> >
> > +             if (metric_events) {
> > +                     perf_stat__collect_metric_expr(tmp_list);
> > +                     if (metricgroup__copy_metric_events(tmp_list, cgrp,
> > +                                                         metric_events,
> > +                                                         &orig_metric_events) < 0)
> > +                             break;
> > +             }
>
> looks good, do you plan to actualy add support for record?

No actually, I still think perf record should use --all-cgroups.

> my ack from last version stays

Thanks!  But I didn't see your ack for this patch set.
(I've only seen it for the perf inject patchset..)

Thanks
Namhyung