From: Namhyung Kim <namhyung@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-perf-users <linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH] perf, android: fixup get_current_dir_name() compilation
Date: Thu, 19 Aug 2021 09:28:13 -0700 [thread overview]
Message-ID: <CAM9d7chOtKDTmiZz7EUDX76BMWRzWJATmJZLcTiLeu5k_qRg0g@mail.gmail.com> (raw)
In-Reply-To: <YRukaQbrgDWhiwGr@localhost.localdomain>
Hello,
On Tue, Aug 17, 2021 at 4:59 AM Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> strdup() prototype doesn't live in stdlib.h .
>
> Add limits.h for PATH_MAX definition as well.
>
> Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
>
> tools/perf/util/get_current_dir_name.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- a/tools/perf/util/get_current_dir_name.c
> +++ b/tools/perf/util/get_current_dir_name.c
> @@ -3,8 +3,9 @@
> //
> #ifndef HAVE_GET_CURRENT_DIR_NAME
> #include "get_current_dir_name.h"
> +#include <limits.h>
> +#include <string.h>
> #include <unistd.h>
> -#include <stdlib.h>
>
> /* Android's 'bionic' library, for one, doesn't have this */
>
next prev parent reply other threads:[~2021-08-19 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 11:58 [PATCH] perf, android: fixup get_current_dir_name() compilation Alexey Dobriyan
2021-08-19 16:28 ` Namhyung Kim [this message]
2021-08-19 18:40 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7chOtKDTmiZz7EUDX76BMWRzWJATmJZLcTiLeu5k_qRg0g@mail.gmail.com \
--to=namhyung@gmail.com \
--cc=acme@kernel.org \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.