Re: [PATCH] perf record: Fix wrong comm in system-wide mode with delay

From: Ian Rogers <irogers@google.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andi Kleen <ak@linux.intel.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf record: Fix wrong comm in system-wide mode with delay
Date: Mon, 30 Aug 2021 10:33:16 -0700	[thread overview]
Message-ID: <CAP-5=fWLUBzsaVNvHpJBMcZY+Ms3gE7OF6i3toOBaW-rYpVFeg@mail.gmail.com> (raw)
In-Reply-To: <20210827233212.3121037-1-namhyung@kernel.org>

On Fri, Aug 27, 2021 at 4:32 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Stephane found that the name of the forked process in a system-wide
> mode is wrong when --delay option is used.  For example,
>
>   # perf record -a --delay=1000  noploop 3
>
> The noploop process will run a busy loop for 3 second.  And on an idle
> machine it should show up at the top in the perf report.  It works
> well without the --delay option.  But if I add the option, it showed
> 'perf' not 'noploop'.
>
>   # perf report -s comm -q | head -3
>       52.94%  perf
>       16.65%  swapper
>       12.04%  chrome
>
> It turned out that the dummy event didn't work at all and it missed
> COMM and MMAP events for the noploop process (and others too).  We
> should enable the dummy event immediately in system-wide mode, as the
> enable-on-exec would work only for task events.
>
> With this change,
>
>   # perf report -s comm -q | head -3
>       52.75%  noploop
>       17.03%  swapper
>       12.83%  chrome
>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Reported-by: Stephane Eranian <eranian@google.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/builtin-record.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 548c1dbde6c5..acfe66e31cf0 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -910,7 +910,8 @@ static int record__open(struct record *rec)
>                  * Enable the dummy event when the process is forked for
>                  * initial_delay, immediately for system wide.
>                  */
> -               if (opts->initial_delay && !pos->immediate)
> +               if (opts->initial_delay && !pos->immediate &&
> +                   !target__has_cpu(&opts->target))
>                         pos->core.attr.enable_on_exec = 1;
>                 else
>                         pos->immediate = 1;
> --
> 2.33.0.259.gc128427fd7-goog
>