Re: [PATCH] perf trace: Ensure read cmdlines are null terminated.

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf trace: Ensure read cmdlines are null terminated.
Date: Tue, 2 Mar 2021 09:36:02 -0300	[thread overview]
Message-ID: <YD4xMrrbRqhIuLmV@kernel.org> (raw)
In-Reply-To: <CAM9d7ci2GpSuj88qAphQxBSEvaOoQg=9r8ah5GjrdFojSQ-28w@mail.gmail.com>

Em Mon, Mar 01, 2021 at 04:50:50PM +0900, Namhyung Kim escreveu:
> Hi Ian,
> 
> On Sat, Feb 27, 2021 at 7:14 AM Ian Rogers <irogers@google.com> wrote:
> >
> > Issue detected by address sanitizer.
> >
> > Fixes: cd4ceb63438e (perf util: Save pid-cmdline mapping into tracing header)
> > Signed-off-by: Ian Rogers <irogers@google.com>
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applied.

- Arnaldo

> Thanks,
> Namhyung
> 
> > ---
> >  tools/perf/util/trace-event-read.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/util/trace-event-read.c b/tools/perf/util/trace-event-read.c
> > index f507dff713c9..8a01af783310 100644
> > --- a/tools/perf/util/trace-event-read.c
> > +++ b/tools/perf/util/trace-event-read.c
> > @@ -361,6 +361,7 @@ static int read_saved_cmdline(struct tep_handle *pevent)
> >                 pr_debug("error reading saved cmdlines\n");
> >                 goto out;
> >         }
> > +       buf[ret] = '\0';
> >
> >         parse_saved_cmdline(pevent, buf, size);
> >         ret = 0;
> > --
> > 2.30.1.766.gb4fecdf3b7-goog
> >

-- 

- Arnaldo