From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Song Liu <songliubraving@fb.com>, Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
acme@redhat.com, namhyung@kernel.org, jolsa@kernel.org
Subject: Re: [PATCH v2 1/3] perf-stat: introduce bperf, share hardware PMCs with BPF
Date: Tue, 23 Mar 2021 09:25:52 -0300 [thread overview]
Message-ID: <YFneUHDiAt8Rg0cc@kernel.org> (raw)
In-Reply-To: <YFTwdWxUvqHDNe1x@kernel.org>
Em Fri, Mar 19, 2021 at 03:41:57PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Mar 18, 2021 at 10:15:13PM +0100, Jiri Olsa escreveu:
> > On Tue, Mar 16, 2021 at 02:18:35PM -0700, Song Liu wrote:
> > > bperf is off by default. To enable it, pass --bpf-counters option to
> > > perf-stat. bperf uses a BPF hashmap to share information about BPF
> > > programs and maps used by bperf. This map is pinned to bpffs. The default
> > > path is /sys/fs/bpf/perf_attr_map. The user could change the path with
> > > option --bpf-attr-map.
> > >
> > > Signed-off-by: Song Liu <songliubraving@fb.com>
> >
> > Reviewed-by: Jiri Olsa <jolsa@redhat.com>
>
> After applying just this first patch in the series I'm getting this
> after a 'make -C tools/ clean', now I'm checking if I need some new
> clang, ideas?
Works now with clang from fedora 33, I was using a locally built, older,
now I get this when trying as non-root, expected, but we need to improve
the wording.
[acme@five perf]$ perf stat --bpf-counters sleep 1
Failed to lock perf_event_attr map
[acme@five perf]$
> - Arnaldo
>
> [acme@quaco perf]$ make O=/tmp/build/perf -C tools/perf BUILD_BPF_SKEL=1 PYTHON=python3 install-bin
> make: Entering directory '/home/acme/git/perf/tools/perf'
> BUILD: Doing 'make -j8' parallel build
> Warning: Kernel ABI header at 'tools/include/uapi/linux/kvm.h' differs from latest version at 'include/uapi/linux/kvm.h'
> diff -u tools/include/uapi/linux/kvm.h include/uapi/linux/kvm.h
> Warning: Kernel ABI header at 'tools/perf/arch/mips/entry/syscalls/syscall_n64.tbl' differs from latest version at 'arch/mips/kernel/syscalls/syscall_n64.tbl'
> diff -u tools/perf/arch/mips/entry/syscalls/syscall_n64.tbl arch/mips/kernel/syscalls/syscall_n64.tbl
>
> Auto-detecting system features:
> ... dwarf: [ on ]
> ... dwarf_getlocations: [ on ]
> ... glibc: [ on ]
> ... libbfd: [ on ]
> ... libbfd-buildid: [ on ]
> ... libcap: [ on ]
> ... libelf: [ on ]
> ... libnuma: [ on ]
> ... numa_num_possible_cpus: [ on ]
> ... libperl: [ on ]
> ... libpython: [ on ]
> ... libcrypto: [ on ]
> ... libunwind: [ on ]
> ... libdw-dwarf-unwind: [ on ]
> ... zlib: [ on ]
> ... lzma: [ on ]
> ... get_cpuid: [ on ]
> ... bpf: [ on ]
> ... libaio: [ on ]
> ... libzstd: [ on ]
> ... disassembler-four-args: [ on ]
>
> GEN /tmp/build/perf/common-cmds.h
> CC /tmp/build/perf/exec-cmd.o
> MKDIR /tmp/build/perf/fd/
> MKDIR /tmp/build/perf/fs/
> CC /tmp/build/perf/fs/fs.o
> CC /tmp/build/perf/event-parse.o
> CC /tmp/build/perf/fd/array.o
> CC /tmp/build/perf/core.o
> GEN /tmp/build/perf/bpf_helper_defs.h
> CC /tmp/build/perf/event-plugin.o
> MKDIR /tmp/build/perf/staticobjs/
> PERF_VERSION = 5.12.rc2.g3df07f57f205
> CC /tmp/build/perf/staticobjs/libbpf.o
> CC /tmp/build/perf/cpu.o
> LD /tmp/build/perf/fd/libapi-in.o
> CC /tmp/build/perf/cpumap.o
> CC /tmp/build/perf/help.o
> MKDIR /tmp/build/perf/fs/
> CC /tmp/build/perf/fs/tracing_path.o
> CC /tmp/build/perf/fs/cgroup.o
> CC /tmp/build/perf/trace-seq.o
> CC /tmp/build/perf/pager.o
> CC /tmp/build/perf/parse-options.o
> LD /tmp/build/perf/fs/libapi-in.o
> CC /tmp/build/perf/debug.o
> CC /tmp/build/perf/str_error_r.o
> CC /tmp/build/perf/run-command.o
> CC /tmp/build/perf/sigchain.o
> LD /tmp/build/perf/libapi-in.o
> AR /tmp/build/perf/libapi.a
> CC /tmp/build/perf/subcmd-config.o
> CC /tmp/build/perf/threadmap.o
> CC /tmp/build/perf/evsel.o
> CC /tmp/build/perf/parse-filter.o
> MKDIR /tmp/build/perf/staticobjs/
> CC /tmp/build/perf/staticobjs/bpf.o
> CC /tmp/build/perf/evlist.o
> CC /tmp/build/perf/parse-utils.o
> CC /tmp/build/perf/kbuffer-parse.o
> CC /tmp/build/perf/tep_strerror.o
> CC /tmp/build/perf/mmap.o
> CC /tmp/build/perf/zalloc.o
> CC /tmp/build/perf/event-parse-api.o
> LD /tmp/build/perf/libsubcmd-in.o
> AR /tmp/build/perf/libsubcmd.a
> CC /tmp/build/perf/xyarray.o
> LD /tmp/build/perf/libtraceevent-in.o
> LINK /tmp/build/perf/libtraceevent.a
> CC /tmp/build/perf/staticobjs/nlattr.o
> CC /tmp/build/perf/staticobjs/btf.o
> CC /tmp/build/perf/lib.o
> CC /tmp/build/perf/staticobjs/libbpf_errno.o
> CC /tmp/build/perf/staticobjs/str_error.o
> CC /tmp/build/perf/staticobjs/netlink.o
> CC /tmp/build/perf/staticobjs/bpf_prog_linfo.o
> CC /tmp/build/perf/staticobjs/libbpf_probes.o
> LD /tmp/build/perf/libperf-in.o
> AR /tmp/build/perf/libperf.a
> MKDIR /tmp/build/perf/pmu-events/
> HOSTCC /tmp/build/perf/pmu-events/json.o
> CC /tmp/build/perf/plugin_jbd2.o
> CC /tmp/build/perf/staticobjs/xsk.o
> MKDIR /tmp/build/perf/pmu-events/
> HOSTCC /tmp/build/perf/pmu-events/jsmn.o
> CC /tmp/build/perf/staticobjs/hashmap.o
> LD /tmp/build/perf/plugin_jbd2-in.o
> CC /tmp/build/perf/staticobjs/btf_dump.o
> CC /tmp/build/perf/plugin_hrtimer.o
> HOSTCC /tmp/build/perf/pmu-events/jevents.o
> LD /tmp/build/perf/plugin_hrtimer-in.o
> CC /tmp/build/perf/plugin_kmem.o
> CC /tmp/build/perf/staticobjs/ringbuf.o
> LD /tmp/build/perf/plugin_kmem-in.o
> CC /tmp/build/perf/plugin_kvm.o
> HOSTLD /tmp/build/perf/pmu-events/jevents-in.o
> CC /tmp/build/perf/perf-read-vdso32
> CC /tmp/build/perf/plugin_mac80211.o
> LD /tmp/build/perf/plugin_kvm-in.o
> CC /tmp/build/perf/plugin_sched_switch.o
> CC /tmp/build/perf/plugin_function.o
> MKDIR /tmp/build/perf/jvmti/
> CC /tmp/build/perf/jvmti/libjvmti.o
> LD /tmp/build/perf/plugin_mac80211-in.o
> GEN perf-archive
> LD /tmp/build/perf/plugin_sched_switch-in.o
> CC /tmp/build/perf/plugin_futex.o
> CC /tmp/build/perf/plugin_xen.o
> CC /tmp/build/perf/plugin_scsi.o
> LD /tmp/build/perf/plugin_function-in.o
> CC /tmp/build/perf/plugin_cfg80211.o
> LD /tmp/build/perf/plugin_futex-in.o
> LD /tmp/build/perf/plugin_xen-in.o
> LINK /tmp/build/perf/plugin_jbd2.so
> LINK /tmp/build/perf/plugin_hrtimer.so
> CC /tmp/build/perf/plugin_tlb.o
> LINK /tmp/build/perf/plugin_kmem.so
> LINK /tmp/build/perf/plugin_kvm.so
> LD /tmp/build/perf/plugin_scsi-in.o
> LINK /tmp/build/perf/plugin_mac80211.so
> LINK /tmp/build/perf/plugin_sched_switch.so
> LINK /tmp/build/perf/plugin_function.so
> LINK /tmp/build/perf/plugin_futex.so
> LD /tmp/build/perf/plugin_cfg80211-in.o
> LINK /tmp/build/perf/plugin_xen.so
> LINK /tmp/build/perf/plugin_scsi.so
> LD /tmp/build/perf/plugin_tlb-in.o
> MKDIR /tmp/build/perf/jvmti/
> LINK /tmp/build/perf/plugin_cfg80211.so
> CC /tmp/build/perf/jvmti/jvmti_agent.o
> LINK /tmp/build/perf/plugin_tlb.so
> GEN perf-with-kcore
> CC /tmp/build/perf/jvmti/libstring.o
> CFLAGS= make -C ../bpf/bpftool \
> OUTPUT=/tmp/build/perf/util/bpf_skel/.tmp/ bootstrap
> CC /tmp/build/perf/jvmti/libctype.o
> GEN /tmp/build/perf/libtraceevent-dynamic-list
> LINK /tmp/build/perf/pmu-events/jevents
> DESCEND plugins
> GEN /tmp/build/perf/python/perf.so
> GEN /tmp/build/perf/pmu-events/pmu-events.c
> CC /tmp/build/perf/plugins/plugin_jbd2.o
> CC /tmp/build/perf/plugins/plugin_hrtimer.o
> LD /tmp/build/perf/plugins/plugin_jbd2-in.o
> LD /tmp/build/perf/plugins/plugin_hrtimer-in.o
> CC /tmp/build/perf/plugins/plugin_kmem.o
> CC /tmp/build/perf/plugins/plugin_kvm.o
> LD /tmp/build/perf/jvmti/jvmti-in.o
> LD /tmp/build/perf/plugins/plugin_kmem-in.o
> LINK /tmp/build/perf/libperf-jvmti.so
> CC /tmp/build/perf/plugins/plugin_mac80211.o
> CC /tmp/build/perf/plugins/plugin_sched_switch.o
> CC /tmp/build/perf/pmu-events/pmu-events.o
> LD /tmp/build/perf/plugins/plugin_kvm-in.o
> CC /tmp/build/perf/plugins/plugin_function.o
> LD /tmp/build/perf/plugins/plugin_mac80211-in.o
> CC /tmp/build/perf/plugins/plugin_futex.o
> LD /tmp/build/perf/plugins/plugin_sched_switch-in.o
> CC /tmp/build/perf/plugins/plugin_xen.o
> LD /tmp/build/perf/plugins/plugin_function-in.o
> CC /tmp/build/perf/plugins/plugin_scsi.o
> LD /tmp/build/perf/plugins/plugin_futex-in.o
> CC /tmp/build/perf/plugins/plugin_cfg80211.o
> LD /tmp/build/perf/plugins/plugin_xen-in.o
> CC /tmp/build/perf/plugins/plugin_tlb.o
> LD /tmp/build/perf/plugins/plugin_scsi-in.o
> LD /tmp/build/perf/plugins/plugin_cfg80211-in.o
> LINK /tmp/build/perf/plugins/plugin_jbd2.so
> LINK /tmp/build/perf/plugins/plugin_hrtimer.so
> LINK /tmp/build/perf/plugins/plugin_kmem.so
> LINK /tmp/build/perf/plugins/plugin_kvm.so
> LINK /tmp/build/perf/plugins/plugin_mac80211.so
> LD /tmp/build/perf/plugins/plugin_tlb-in.o
> LINK /tmp/build/perf/plugins/plugin_function.so
> LINK /tmp/build/perf/plugins/plugin_sched_switch.so
> LINK /tmp/build/perf/plugins/plugin_futex.so
> LINK /tmp/build/perf/plugins/plugin_xen.so
> LINK /tmp/build/perf/plugins/plugin_scsi.so
> LINK /tmp/build/perf/plugins/plugin_cfg80211.so
> LINK /tmp/build/perf/plugins/plugin_tlb.so
> INSTALL trace_plugins
> LD /tmp/build/perf/pmu-events/pmu-events-in.o
>
> Auto-detecting system features:
> ... libbfd: [ on ]
> ... disassembler-four-args: [ on ]
> ... zlib: [ on ]
> ... libcap: [ on ]
> ... clang-bpf-co-re: [ on ]
>
> MKDIR /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/
> MKDIR /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/main.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/common.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/json_writer.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/gen.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/btf.o
> GEN /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/bpf_helper_defs.h
> MKDIR /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/
> MKDIR /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/libbpf.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/bpf.o
> MKDIR /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/nlattr.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/btf.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/libbpf_errno.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/str_error.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/netlink.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/bpf_prog_linfo.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/libbpf_probes.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/xsk.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/hashmap.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/btf_dump.o
> CC /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/ringbuf.o
> LD /tmp/build/perf/staticobjs/libbpf-in.o
> LINK /tmp/build/perf/libbpf.a
> CLANG /tmp/build/perf/util/bpf_skel/.tmp/bpf_prog_profiler.bpf.o
> CLANG /tmp/build/perf/util/bpf_skel/.tmp/bperf_leader.bpf.o
> CLANG /tmp/build/perf/util/bpf_skel/.tmp/bperf_follower.bpf.o
> LD /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/staticobjs/libbpf-in.o
> LINK /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/libbpf/libbpf.a
> LINK /tmp/build/perf/util/bpf_skel/.tmp//bootstrap/bpftool
> GEN-SKEL /tmp/build/perf/util/bpf_skel/bpf_prog_profiler.skel.h
> GEN-SKEL /tmp/build/perf/util/bpf_skel/bperf_leader.skel.h
> GEN-SKEL /tmp/build/perf/util/bpf_skel/bperf_follower.skel.h
> libbpf: map 'prev_readings': unexpected def kind var.
> Error: failed to open BPF object file: Invalid argument
> libbpf: map 'diff_readings': unexpected def kind var.
> Error: failed to open BPF object file: Invalid argument
> make[2]: *** [Makefile.perf:1029: /tmp/build/perf/util/bpf_skel/bperf_leader.skel.h] Error 255
> make[2]: *** Waiting for unfinished jobs....
> make[2]: *** [Makefile.perf:1029: /tmp/build/perf/util/bpf_skel/bperf_follower.skel.h] Error 255
> make[1]: *** [Makefile.perf:236: sub-make] Error 2
> make: *** [Makefile:110: install-bin] Error 2
> make: Leaving directory '/home/acme/git/perf/tools/perf'
> [acme@quaco perf]$ clang -v
> clang version 11.0.0 (https://github.com/llvm/llvm-project 67420f1b0e9c673ee638f2680fa83f468019004f)
> Target: x86_64-unknown-linux-gnu
> Thread model: posix
> InstalledDir: /usr/local/bin
> Found candidate GCC installation: /usr/lib/gcc/x86_64-redhat-linux/10
> Selected GCC installation: /usr/lib/gcc/x86_64-redhat-linux/10
> Candidate multilib: .;@m64
> Candidate multilib: 32;@m32
> Selected multilib: .;@m64
> [acme@quaco perf]$
--
- Arnaldo
next prev parent reply other threads:[~2021-03-23 12:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 21:18 [PATCH v2 0/3] perf-stat: share hardware PMCs with BPF Song Liu
2021-03-16 21:18 ` [PATCH v2 1/3] perf-stat: introduce bperf, " Song Liu
2021-03-18 5:54 ` Namhyung Kim
2021-03-18 7:22 ` Song Liu
2021-03-18 13:49 ` Namhyung Kim
2021-03-18 17:16 ` Song Liu
2021-03-18 21:15 ` Jiri Olsa
2021-03-19 18:41 ` Arnaldo Carvalho de Melo
2021-03-19 18:55 ` Jiri Olsa
2021-03-19 22:06 ` Song Liu
2021-03-23 0:53 ` Song Liu
2021-03-23 12:25 ` Arnaldo Carvalho de Melo [this message]
2021-03-23 12:37 ` Arnaldo Carvalho de Melo
2021-03-23 18:27 ` Arnaldo Carvalho de Melo
2021-03-16 21:18 ` [PATCH v2 2/3] perf-stat: measure t0 and ref_time after enable_counters() Song Liu
2021-03-16 21:18 ` [PATCH v2 3/3] perf-test: add a test for perf-stat --bpf-counters option Song Liu
2021-03-18 6:07 ` Namhyung Kim
2021-03-18 7:39 ` Song Liu
2021-03-17 5:29 ` [PATCH v2 0/3] perf-stat: share hardware PMCs with BPF Namhyung Kim
2021-03-17 9:19 ` Jiri Olsa
2021-03-17 13:11 ` Arnaldo Carvalho de Melo
2021-03-18 3:52 ` Song Liu
2021-03-18 4:32 ` Namhyung Kim
2021-03-18 7:03 ` Song Liu
2021-03-18 21:14 ` Jiri Olsa
2021-03-19 0:09 ` Arnaldo
2021-03-19 0:22 ` Song Liu
2021-03-19 0:54 ` Namhyung Kim
2021-03-19 15:35 ` Arnaldo Carvalho de Melo
2021-03-19 15:58 ` Namhyung Kim
2021-03-19 16:14 ` Song Liu
2021-03-23 21:10 ` Arnaldo Carvalho de Melo
2021-03-23 21:26 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFneUHDiAt8Rg0cc@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.