Re: [PATCH] perf: util/mem-events.h: Remove unnecessary struct declaration

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Kan Liang <kan.liang@linux.intel.com>,
	Leo Yan <leo.yan@linaro.org>, Ian Rogers <irogers@google.com>,
	linux-kernel@vger.kernel.org, kael_w@yeah.net
Subject: Re: [PATCH] perf: util/mem-events.h: Remove unnecessary struct declaration
Date: Tue, 6 Apr 2021 13:33:12 -0300	[thread overview]
Message-ID: <YGyNSMDNlxQk5j7E@kernel.org> (raw)
In-Reply-To: <20210406105104.675879-1-wanjiabing@vivo.com>

Em Tue, Apr 06, 2021 at 06:51:02PM +0800, Wan Jiabing escreveu:
> struct mem_info is defined at 22nd line.
> The declaration here is unnecessary. Remove it.

Thanks, applied.

- Arnaldo

> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  tools/perf/util/mem-events.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
> index 755cef7e0625..5ddbeaa057b0 100644
> --- a/tools/perf/util/mem-events.h
> +++ b/tools/perf/util/mem-events.h
> @@ -44,7 +44,6 @@ bool is_mem_loads_aux_event(struct evsel *leader);
>  
>  void perf_mem_events__list(void);
>  
> -struct mem_info;
>  int perf_mem__tlb_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
>  int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
>  int perf_mem__snp_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
> -- 
> 2.25.1
> 

-- 

- Arnaldo