All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Jason Yan'" <yanaijie@huawei.com>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<sj1557.seo@samsung.com>
Subject: RE: [PATCH] exfat: remove the assignment of 0 to bool variable
Date: Thu, 16 Apr 2020 15:34:33 +0900	[thread overview]
Message-ID: <003f01d613b9$17864000$4692c000$@samsung.com> (raw)
In-Reply-To: <20200414120225.35540-1-yanaijie@huawei.com>

> There is no need to init 'sync' in exfat_set_vol_flags().
> This also fixes the following coccicheck warning:
> 
> fs/exfat/super.c:104:6-10: WARNING: Assignment of 0/1 to bool variable
> 
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Pushed it to exfat dev.

Thanks for your patch!
> ---
>  fs/exfat/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/exfat/super.c b/fs/exfat/super.c index
> 16ed202ef527..b86755468904 100644
> --- a/fs/exfat/super.c
> +++ b/fs/exfat/super.c
> @@ -101,7 +101,7 @@ int exfat_set_vol_flags(struct super_block *sb,
> unsigned short new_flag)  {
>  	struct exfat_sb_info *sbi = EXFAT_SB(sb);
>  	struct pbr64 *bpb;
> -	bool sync = 0;
> +	bool sync;
> 
>  	/* flags are not changed */
>  	if (sbi->vol_flag == new_flag)
> --
> 2.21.1



      reply	other threads:[~2020-04-16  6:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200414113819epcas1p4eafa861bec639fcdcb931fb68c1086ce@epcas1p4.samsung.com>
2020-04-14 12:02 ` [PATCH] exfat: remove the assignment of 0 to bool variable Jason Yan
2020-04-16  6:34   ` Namjae Jeon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003f01d613b9$17864000$4692c000$@samsung.com' \
    --to=namjae.jeon@samsung.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sj1557.seo@samsung.com \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.