From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D22AC4708C for ; Fri, 28 May 2021 05:23:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46B0D613BA for ; Fri, 28 May 2021 05:23:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233565AbhE1FYn (ORCPT ); Fri, 28 May 2021 01:24:43 -0400 Received: from lizzard.sbs.de ([194.138.37.39]:46327 "EHLO lizzard.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234995AbhE1FYf (ORCPT ); Fri, 28 May 2021 01:24:35 -0400 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 14S5MVwG009038 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 28 May 2021 07:22:31 +0200 Received: from [167.87.36.150] ([167.87.36.150]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 14S5MUQK010752; Fri, 28 May 2021 07:22:30 +0200 Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am65-main: Add ICSSG MDIO nodes From: Jan Kiszka To: Suman Anna , Nishanth Menon Cc: Grygorii Strashko , Vignesh Raghavendra , Kishon Vijay Abraham I , Lokesh Vutla , Grzegorz Jaszczyk , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <20210514224759.9987-1-s-anna@ti.com> <20210514224759.9987-2-s-anna@ti.com> Message-ID: <00fbd9c1-ed43-822c-06bf-9642b5c03568@siemens.com> Date: Fri, 28 May 2021 07:22:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28.05.21 07:09, Jan Kiszka wrote: > On 15.05.21 00:47, Suman Anna wrote: >> From: Roger Quadros >> >> The ICSSGs on K3 AM65x SoCs contain an MDIO controller that can >> be used to control external PHYs associated with the Industrial >> Ethernet peripherals within each ICSSG instance. The MDIO module >> used within the ICSSG is similar to the MDIO Controller used >> in TI Davinci SoCs. A bus frequency of 1 MHz is chosen for the >> MDIO operations. >> >> The nodes are added and enabled in the common k3-am65-main.dtsi >> file by default, and disabled in the existing AM65 board dts >> files. These nodes need pinctrl lines, and so should be enabled >> only on boards where they are actually wired and pinned out for >> ICSSG Ethernet. Any new board dts file should disable these if >> they are not sure. >> >> Signed-off-by: Roger Quadros >> [s-anna@ti.com: move the disabled status to board dts files] >> Signed-off-by: Suman Anna >> --- >> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 12 ++++++++ >> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 30 +++++++++++++++++++ >> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 12 ++++++++ >> 3 files changed, 54 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >> index de763ca9251c..63140eaba524 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >> @@ -653,3 +653,15 @@ &pcie1_rc { >> &pcie1_ep { >> status = "disabled"; >> }; >> + >> +&icssg0_mdio { >> + status = "disabled"; >> +}; >> + >> +&icssg1_mdio { >> + status = "disabled"; >> +}; >> + >> +&icssg2_mdio { >> + status = "disabled"; >> +}; > > We will need this here for PRU networking. What would be the impact of > leaving it enabled already at this stage? > Ah, now reading our backlog completely - there will be more coming in to this file than not disabling icssg mdio (and that only for mdio0). So: Acked-by: Jan Kiszka Jan PS: How far are we away from icssg-prueth? -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F53BC4708C for ; Fri, 28 May 2021 05:24:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07B2761131 for ; Fri, 28 May 2021 05:24:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07B2761131 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siemens.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:Cc:To:From:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=nVoSHPafdlarONYj3EdWS9OCKfHVj95W84e5xRQMtpI=; b=01zkv8sxwpNbGh8QTfeiM9c8lc Pm8BRxP66pUQPbHqMTSQvbn2Dkdkl0eKxTgeCh03txc3s2IQcdwegddjH9JGz8gHpoyWiu7soxSCr WrQZnCsfwaXcEhw3HCPagB7ohD4m9P3zqpLsLIPMjgMd2RLWHNDBJ6sk0kZaZA1hdm/gWfn5cQ/bz RueAV5hwT6K0L6wvlLBxVjX2ONetUdxaDpKS0nA1IyQCQXtfR2T0iTpMiAYS3dzzOXXt3l3aZy8Jm kfNomq4QL3ukjXDAVkuX8bC6aFM7NXsJNnsffAD7wPkgkR6WKBQCpJv1Q1TBDKWauZ0ODkR00bghD tXyI7FLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmUxD-00CEAe-NY; Fri, 28 May 2021 05:22:39 +0000 Received: from lizzard.sbs.de ([194.138.37.39]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmUx9-00CE8M-Dq for linux-arm-kernel@lists.infradead.org; Fri, 28 May 2021 05:22:37 +0000 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 14S5MVwG009038 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 28 May 2021 07:22:31 +0200 Received: from [167.87.36.150] ([167.87.36.150]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 14S5MUQK010752; Fri, 28 May 2021 07:22:30 +0200 Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am65-main: Add ICSSG MDIO nodes From: Jan Kiszka To: Suman Anna , Nishanth Menon Cc: Grygorii Strashko , Vignesh Raghavendra , Kishon Vijay Abraham I , Lokesh Vutla , Grzegorz Jaszczyk , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <20210514224759.9987-1-s-anna@ti.com> <20210514224759.9987-2-s-anna@ti.com> Message-ID: <00fbd9c1-ed43-822c-06bf-9642b5c03568@siemens.com> Date: Fri, 28 May 2021 07:22:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_222235_807791_C9FB85EC X-CRM114-Status: GOOD ( 19.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28.05.21 07:09, Jan Kiszka wrote: > On 15.05.21 00:47, Suman Anna wrote: >> From: Roger Quadros >> >> The ICSSGs on K3 AM65x SoCs contain an MDIO controller that can >> be used to control external PHYs associated with the Industrial >> Ethernet peripherals within each ICSSG instance. The MDIO module >> used within the ICSSG is similar to the MDIO Controller used >> in TI Davinci SoCs. A bus frequency of 1 MHz is chosen for the >> MDIO operations. >> >> The nodes are added and enabled in the common k3-am65-main.dtsi >> file by default, and disabled in the existing AM65 board dts >> files. These nodes need pinctrl lines, and so should be enabled >> only on boards where they are actually wired and pinned out for >> ICSSG Ethernet. Any new board dts file should disable these if >> they are not sure. >> >> Signed-off-by: Roger Quadros >> [s-anna@ti.com: move the disabled status to board dts files] >> Signed-off-by: Suman Anna >> --- >> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 12 ++++++++ >> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 30 +++++++++++++++++++ >> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 12 ++++++++ >> 3 files changed, 54 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >> index de763ca9251c..63140eaba524 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >> @@ -653,3 +653,15 @@ &pcie1_rc { >> &pcie1_ep { >> status = "disabled"; >> }; >> + >> +&icssg0_mdio { >> + status = "disabled"; >> +}; >> + >> +&icssg1_mdio { >> + status = "disabled"; >> +}; >> + >> +&icssg2_mdio { >> + status = "disabled"; >> +}; > > We will need this here for PRU networking. What would be the impact of > leaving it enabled already at this stage? > Ah, now reading our backlog completely - there will be more coming in to this file than not disabling icssg mdio (and that only for mdio0). So: Acked-by: Jan Kiszka Jan PS: How far are we away from icssg-prueth? -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel