From: Kalle Valo <kvalo@codeaurora.org>
To: Ming Chen <Ming.Chen@watchguard.com>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Ming Chen" <ming032217@gmail.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v4] mac80211: Drop the packets whose source or destination mac address is empty
Date: Tue, 19 Nov 2019 09:41:36 +0000 [thread overview]
Message-ID: <0101016e8309ed71-c2031187-906f-4d32-8ba0-e8420c76fe1e-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <DM6PR10MB2873E994ABFB1798B36CE49B9A4C0@DM6PR10MB2873.namprd10.prod.outlook.com> (Ming Chen's message of "Tue, 19 Nov 2019 08:03:24 +0000")
Ming Chen <Ming.Chen@watchguard.com> writes:
>> > Dropping this kind of error packet before it goes into the driver,
>> > should be the right direction.
>>
>> So I still wonder why this happens from higher up in the stack. If there's a
>> legitimate reason, maybe dropping the packet is not the right thing? And if
>> there is *no* legitimate reason, maybe the packet should be dropped higher
>> up in the stack instead?
>>
>> What kind of packets does this happen with?
>
> [Ming Chen] It should an ARP packet. I can see this kind of packet
> before ARP table is complete. If so, how about dropping it in the
> function of ieee80211_subif_start_xmit?
The question here is why are you seeing this but nobody else? Are you
using some special protocol, do you have some changes in the kernel
which cause this or what could explain this behaviour?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-11-19 9:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 6:08 [PATCH v4] mac80211: Drop the packets whose source or destination mac address is empty Ming Chen
2019-11-18 11:32 ` Toke Høiland-Jørgensen
2019-11-18 12:15 ` Johannes Berg
2019-11-19 8:03 ` Ming Chen
2019-11-19 9:41 ` Kalle Valo [this message]
[not found] ` <0101016e8309e9b1-7bb90226-11bb-4b89-8236-952999e578a8-000000@us-west-2.amazonses.com>
2019-11-20 7:11 ` Ming Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0101016e8309ed71-c2031187-906f-4d32-8ba0-e8420c76fe1e-000000@us-west-2.amazonses.com \
--to=kvalo@codeaurora.org \
--cc=Ming.Chen@watchguard.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=ming032217@gmail.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.