All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sibi Sankar <sibis@codeaurora.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org,
	ulf.hansson@linaro.org, agross@kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, mark.rutland@arm.com,
	swboyd@chromium.org, dianders@chromium.org
Subject: Re: [PATCH 2/6] dt-bindings: power: Add rpmh power-domain bindings for SM8150
Date: Wed, 20 Nov 2019 12:15:27 +0000	[thread overview]
Message-ID: <0101016e88bd2571-928d6d73-00f0-433d-8baf-b288f27520a9-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <9eb5e99f-836b-01a6-8b5c-d1fffd1a482b@codeaurora.org>

On 2019-11-20 09:27, Rajendra Nayak wrote:
> On 11/18/2019 11:10 PM, Sibi Sankar wrote:
>> Add RPMH power-domain bindings for the SM8150 family of SoCs.
>> 
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>>   .../devicetree/bindings/power/qcom,rpmpd.txt       |  1 +
>>   include/dt-bindings/power/qcom-rpmpd.h             | 14 
>> ++++++++++++++
>>   2 files changed, 15 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.txt 
>> b/Documentation/devicetree/bindings/power/qcom,rpmpd.txt
>> index bc75bf49cdaea..f3bbaa4aef297 100644
>> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.txt
>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.txt
>> @@ -10,6 +10,7 @@ Required Properties:
>>   	* qcom,msm8998-rpmpd: RPM Power domain for the msm8998 family of 
>> SoC
>>   	* qcom,qcs404-rpmpd: RPM Power domain for the qcs404 family of SoC
>>   	* qcom,sdm845-rpmhpd: RPMh Power domain for the sdm845 family of 
>> SoC
>> +	* qcom,sm8150-rpmhpd: RPMh Power domain for the sm8150 family of SoC
>>    - #power-domain-cells: number of cells in Power domain specifier
>>   	must be 1.
>>    - operating-points-v2: Phandle to the OPP table for the Power 
>> domain.
>> diff --git a/include/dt-bindings/power/qcom-rpmpd.h 
>> b/include/dt-bindings/power/qcom-rpmpd.h
>> index f05f8b1808ec9..7d43bafc0026b 100644
>> --- a/include/dt-bindings/power/qcom-rpmpd.h
>> +++ b/include/dt-bindings/power/qcom-rpmpd.h
>> @@ -15,12 +15,26 @@
>>   #define SDM845_GFX	7
>>   #define SDM845_MSS	8
>>   +/* SM8150 Power Domain Indexes */
>> +#define SM8150_MSS	0
>> +#define SM8150_EBI	1
>> +#define SM8150_LMX	2
>> +#define SM8150_LCX	3
>> +#define SM8150_GFX	4
>> +#define SM8150_MX	5
>> +#define SM8150_MX_AO	6
>> +#define SM8150_CX	7
>> +#define SM8150_CX_AO	8
>> +#define SM8150_MMCX	9
>> +#define SM8150_MMCX_AO	10
>> +
>>   /* SDM845 Power Domain performance levels */
> 
> You could perhaps remove this comment, or remove the
> SDM845 from it.

yes will remove it

> 
> Reviewed-by: Rajendra Nayak <rnayak@codeaurora.org>
> 
>>   #define RPMH_REGULATOR_LEVEL_RETENTION	16
>>   #define RPMH_REGULATOR_LEVEL_MIN_SVS	48
>>   #define RPMH_REGULATOR_LEVEL_LOW_SVS	64
>>   #define RPMH_REGULATOR_LEVEL_SVS	128
>>   #define RPMH_REGULATOR_LEVEL_SVS_L1	192
>> +#define RPMH_REGULATOR_LEVEL_SVS_L2	224
>>   #define RPMH_REGULATOR_LEVEL_NOM	256
>>   #define RPMH_REGULATOR_LEVEL_NOM_L1	320
>>   #define RPMH_REGULATOR_LEVEL_NOM_L2	336
>> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.

  parent reply	other threads:[~2019-11-20 12:15 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191118173944.27043-1-sibis@codeaurora.org>
2019-11-18 17:40 ` [PATCH 1/6] soc: qcom: rpmhpd: Set 'active_only' for active only power domains Sibi Sankar
2019-11-20  2:39   ` Bjorn Andersson
2019-11-20 12:14     ` Sibi Sankar
2019-11-18 17:40 ` [PATCH 2/6] dt-bindings: power: Add rpmh power-domain bindings for SM8150 Sibi Sankar
2019-11-20  3:57   ` Rajendra Nayak
     [not found]   ` <9eb5e99f-836b-01a6-8b5c-d1fffd1a482b@codeaurora.org>
2019-11-20 12:15     ` Sibi Sankar [this message]
2019-12-03 21:54   ` Rob Herring
2019-11-18 17:40 ` [PATCH 3/6] soc: qcom: rpmhpd: Add SM8150 RPMH power-domains Sibi Sankar
2019-11-20  2:31   ` Bjorn Andersson
2019-11-20  4:02   ` Rajendra Nayak
     [not found]   ` <896c7edd-c511-3cdf-7281-01c894facc3b@codeaurora.org>
2019-11-20 12:16     ` Sibi Sankar
2019-11-18 17:40 ` [PATCH 4/6] dt-bindings: power: Add rpmh power-domain bindings for sc7180 Sibi Sankar
2019-11-20  2:31   ` Bjorn Andersson
2019-12-03 21:55   ` Rob Herring
2019-11-18 17:40 ` [PATCH 5/6] soc: qcom: rpmhpd: Add SC7180 RPMH power-domains Sibi Sankar
2019-11-18 17:40 ` [PATCH 6/6] arm64: dts: sm8150: Add rpmh power-domain node Sibi Sankar
2019-12-12  7:39   ` Bjorn Andersson
2019-12-13 15:31     ` Sibi Sankar
     [not found] ` <0101016e7f99aa17-22b1062e-9922-40e4-ae7e-8b91210bb12c-000000@us-west-2.amazonses.com>
2019-11-19 18:50   ` [PATCH 2/6] dt-bindings: power: Add rpmh power-domain bindings for SM8150 Stephen Boyd
2019-11-20 12:08     ` Sibi Sankar
     [not found] ` <0101016e7f99b9a0-6c4e46e3-ff77-4cc1-95f6-9561975eedc4-000000@us-west-2.amazonses.com>
2019-11-19 18:51   ` [PATCH 3/6] soc: qcom: rpmhpd: Add SM8150 RPMH power-domains Stephen Boyd
     [not found] ` <0101016e7f99ca93-ab6c1c1c-e20d-48ca-ab03-b8da0890fca8-000000@us-west-2.amazonses.com>
2019-11-19 18:51   ` [PATCH 4/6] dt-bindings: power: Add rpmh power-domain bindings for sc7180 Stephen Boyd
     [not found] ` <0101016e7f99df8a-05504a3e-9962-4255-94e0-706e8186cd0a-000000@us-west-2.amazonses.com>
2019-11-19 18:52   ` [PATCH 5/6] soc: qcom: rpmhpd: Add SC7180 RPMH power-domains Stephen Boyd
2019-11-20 12:09     ` Sibi Sankar
     [not found] ` <0101016e7f99eaca-e623ce91-3e2a-40ae-bf2d-647a786aa7d7-000000@us-west-2.amazonses.com>
2019-11-19 18:52   ` [PATCH 6/6] arm64: dts: sm8150: Add rpmh power-domain node Stephen Boyd
     [not found] ` <0101016e7f99ad2b-2bce2fac-2f02-4b3f-ac64-09942f7251ea-000000@us-west-2.amazonses.com>
2019-11-20  2:29   ` [PATCH 2/6] dt-bindings: power: Add rpmh power-domain bindings for SM8150 Bjorn Andersson
     [not found] ` <0101016e7f99dc94-4513a473-16b3-418a-86cf-a89322016215-000000@us-west-2.amazonses.com>
2019-11-20  2:33   ` [PATCH 5/6] soc: qcom: rpmhpd: Add SC7180 RPMH power-domains Bjorn Andersson
     [not found] ` <0101016e7f99efe5-cee866e3-7031-4ecf-a8a6-4b247e9e69ff-000000@us-west-2.amazonses.com>
2019-11-20  2:35   ` [PATCH 6/6] arm64: dts: sm8150: Add rpmh power-domain node Bjorn Andersson
     [not found] ` <20191118173944.27043-5-sibis@codeaurora.org>
2019-11-20  4:10   ` [PATCH 4/6] dt-bindings: power: Add rpmh power-domain bindings for sc7180 Rajendra Nayak
     [not found] ` <20191118173944.27043-6-sibis@codeaurora.org>
2019-11-20  4:10   ` [PATCH 5/6] soc: qcom: rpmhpd: Add SC7180 RPMH power-domains Rajendra Nayak
     [not found] ` <20191118173944.27043-7-sibis@codeaurora.org>
2019-11-20  4:12   ` [PATCH 6/6] arm64: dts: sm8150: Add rpmh power-domain node Rajendra Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0101016e88bd2571-928d6d73-00f0-433d-8baf-b288f27520a9-000000@us-west-2.amazonses.com \
    --to=sibis@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.