All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Ben Greear <greearb@candelatech.com>
Cc: Krishna Chaitanya <chaitanya.mgit@gmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	ath10k <ath10k@lists.infradead.org>,
	Wen Gong <wgong@codeaurora.org>
Subject: Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio
Date: Mon, 7 Sep 2020 16:07:02 +0000	[thread overview]
Message-ID: <0101017469521a93-4e09b3dc-994c-4ecf-b4e9-f2a05389fd68-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <c69abe52-ccd1-ac73-8691-d87f5ed8be76@candelatech.com> (Ben Greear's message of "Thu, 20 Aug 2020 13:59:13 -0700")

Ben Greear <greearb@candelatech.com> writes:

>>>>>> Here is my original patch to fix this, it is not complex.
>>>>>>
>>>>>> https://patchwork.kernel.org/patch/10249363/
>>>>> Sure, I have shared your patch above :).
>>>> Sent a bit early, any idea why this wasn't upstreamed earlier?
>>>
>>> No, one comment from Michal indicated maybe there were more problems lurking
>>> in this area, but he seemed to be OK with the patch over all.  After that,
>>> it was just ignored.
>>>
>> Now might be a good time to push for it :)
>>
>
> It is generally a waste of time in my experience.  Kalle is the maintainer and should
> be seeing any of this he cares to see.  If he likes the patch, he can apply it or
> something similar.  If you have a reproducible test case, see if the patch fixes
> things, that might help it be accepted.

The problem with yours (Ben's) patches is that you have your own set of
patches for ath10k and your own firmware. So I cannot know at all if
your patches work with upstream ath10k and upstream firmware, and would
need to test the patches myself. But nowadays I just can't find the time
for testing. So if someone else can do the testing and provide a
Tested-on tag it would it increase my confidence level for the patches.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  parent reply	other threads:[~2020-09-07 16:07 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  3:55 [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio Wen Gong
2020-02-14  3:55 ` Wen Gong
2020-08-20  8:32 ` Kalle Valo
2020-08-20  8:32   ` Kalle Valo
2020-08-20  9:19   ` Krishna Chaitanya
2020-08-20  9:19     ` Krishna Chaitanya
2020-08-20  9:26     ` Krishna Chaitanya
2020-08-20  9:26       ` Krishna Chaitanya
2020-08-20 10:20       ` Wen Gong
2020-08-20 10:20         ` Wen Gong
2020-08-20 10:14     ` Wen Gong
2020-08-20 10:14       ` Wen Gong
2020-08-20 10:52       ` Krishna Chaitanya
2020-08-20 10:52         ` Krishna Chaitanya
2020-08-20 14:37         ` Wen Gong
2020-08-20 14:37           ` Wen Gong
2020-08-20 16:08           ` Krishna Chaitanya
2020-08-20 16:08             ` Krishna Chaitanya
2020-08-20 16:32             ` Ben Greear
2020-08-20 16:32               ` Ben Greear
2020-08-20 17:00               ` Krishna Chaitanya
2020-08-20 17:00                 ` Krishna Chaitanya
2020-08-20 17:07                 ` Ben Greear
2020-08-20 17:07                   ` Ben Greear
2020-08-20 17:41                   ` Krishna Chaitanya
2020-08-20 17:41                     ` Krishna Chaitanya
2020-08-20 17:42                     ` Krishna Chaitanya
2020-08-20 17:42                       ` Krishna Chaitanya
2020-08-20 17:53                       ` Ben Greear
2020-08-20 17:53                         ` Ben Greear
2020-08-20 20:15                         ` Krishna Chaitanya
2020-08-20 20:15                           ` Krishna Chaitanya
2020-08-20 20:59                           ` Ben Greear
2020-08-20 20:59                             ` Ben Greear
2020-08-21  2:45                             ` Wen Gong
2020-08-21  2:45                               ` Wen Gong
2020-08-24  4:35                               ` Wen Gong
2020-08-24  4:35                                 ` Wen Gong
2020-09-07 16:07                             ` Kalle Valo [this message]
2020-09-07 16:07                             ` Kalle Valo
2020-09-07 17:18                               ` Ben Greear
2020-09-07 17:18                                 ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0101017469521a93-4e09b3dc-994c-4ecf-b4e9-f2a05389fd68-000000@us-west-2.amazonses.com \
    --to=kvalo@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=chaitanya.mgit@gmail.com \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wgong@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.