From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753439AbdDLIeD (ORCPT ); Wed, 12 Apr 2017 04:34:03 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:5322 "EHLO dggrg01-dlp.huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751393AbdDLIeB (ORCPT ); Wed, 12 Apr 2017 04:34:01 -0400 Subject: Re: [PATCH 2/3] f2fs: shrink blk plug region To: References: <20170327101406.56028-1-yuchao0@huawei.com> <20170327101406.56028-2-yuchao0@huawei.com> CC: , , From: Chao Yu Message-ID: <01ed1c10-f698-8e8c-2f76-f7c61265a844@huawei.com> Date: Wed, 12 Apr 2017 16:33:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170327101406.56028-2-yuchao0@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090204.58EDE665.0037,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 5d1bbc3afbc6002f8e173fbaa94c12a0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, Just reminding, miss merging this patch? :) Thanks, On 2017/3/27 18:14, Chao Yu wrote: > Don't use blk plug covering area where there won't be any IOs being issued. > > Signed-off-by: Chao Yu > --- > fs/f2fs/segment.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index c1a03b0857f9..57a81f9c8c14 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -848,9 +848,8 @@ static int issue_discard_thread(void *data) > if (kthread_should_stop()) > return 0; > > - blk_start_plug(&plug); > - > mutex_lock(&dcc->cmd_lock); > + blk_start_plug(&plug); > list_for_each_entry_safe(dc, tmp, pend_list, list) { > f2fs_bug_on(sbi, dc->state != D_PREP); > > @@ -860,6 +859,7 @@ static int issue_discard_thread(void *data) > if (iter++ > DISCARD_ISSUE_RATE) > break; > } > + blk_finish_plug(&plug); > > list_for_each_entry_safe(dc, tmp, wait_list, list) { > if (dc->state == D_DONE) > @@ -867,8 +867,6 @@ static int issue_discard_thread(void *data) > } > mutex_unlock(&dcc->cmd_lock); > > - blk_finish_plug(&plug); > - > iter = 0; > congestion_wait(BLK_RW_SYNC, HZ/50); > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [PATCH 2/3] f2fs: shrink blk plug region Date: Wed, 12 Apr 2017 16:33:37 +0800 Message-ID: <01ed1c10-f698-8e8c-2f76-f7c61265a844@huawei.com> References: <20170327101406.56028-1-yuchao0@huawei.com> <20170327101406.56028-2-yuchao0@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170327101406.56028-2-yuchao0@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, chao@kernel.org List-Id: linux-f2fs-devel.lists.sourceforge.net Hi Jaegeuk, Just reminding, miss merging this patch? :) Thanks, On 2017/3/27 18:14, Chao Yu wrote: > Don't use blk plug covering area where there won't be any IOs being issued. > > Signed-off-by: Chao Yu > --- > fs/f2fs/segment.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index c1a03b0857f9..57a81f9c8c14 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -848,9 +848,8 @@ static int issue_discard_thread(void *data) > if (kthread_should_stop()) > return 0; > > - blk_start_plug(&plug); > - > mutex_lock(&dcc->cmd_lock); > + blk_start_plug(&plug); > list_for_each_entry_safe(dc, tmp, pend_list, list) { > f2fs_bug_on(sbi, dc->state != D_PREP); > > @@ -860,6 +859,7 @@ static int issue_discard_thread(void *data) > if (iter++ > DISCARD_ISSUE_RATE) > break; > } > + blk_finish_plug(&plug); > > list_for_each_entry_safe(dc, tmp, wait_list, list) { > if (dc->state == D_DONE) > @@ -867,8 +867,6 @@ static int issue_discard_thread(void *data) > } > mutex_unlock(&dcc->cmd_lock); > > - blk_finish_plug(&plug); > - > iter = 0; > congestion_wait(BLK_RW_SYNC, HZ/50); > >