From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3B92C43141 for ; Fri, 15 Nov 2019 14:36:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80F762073A for ; Fri, 15 Nov 2019 14:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573828563; bh=zcYNaxA6BKLXVIrEibaKGpyyFgLeOOLcofq3PI+ecco=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=cyEkb+HTITKOqvd5w1QCi8pbh9fK3Mav+ciuvj0obKv3rt/Tvf9JvlLJQc+9TVnLO UE3mbb15zK/CeZ5V64xAjw04keIHRxP8ZKe5imPolkJvwMC6u4gTpH2Nv2rBI+MZvY CN13WySnANS3iT1lPwBvsUzzsOJNPP3y2Qe0G+yM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727626AbfKOOgC (ORCPT ); Fri, 15 Nov 2019 09:36:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:50896 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727411AbfKOOgC (ORCPT ); Fri, 15 Nov 2019 09:36:02 -0500 Received: from [192.168.1.20] (cpe-24-28-70-126.austin.res.rr.com [24.28.70.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFF4D20733; Fri, 15 Nov 2019 14:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573828561; bh=zcYNaxA6BKLXVIrEibaKGpyyFgLeOOLcofq3PI+ecco=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=PDTXSN7Q9BNaGWYT00xceI6zye3VrA+/YAPDFdajMlZi3HFfpMSjCShVVI6ACm1LF CnqbEPAeehgHGiIY2k55fkCm49x2fbA6wLV6Nc4PC+UnE1OyQkQbkgM4Q6YT9F5OvD IAxsiV8AQN9KM3gn6gtoyf2oWlnTWcbGpB6r6kkQ= Subject: Re: [PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe() To: Rasmus Villemoes Cc: Qiang Zhao , Li Yang , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , lkml , Scott Wood , linux-serial@vger.kernel.org References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-33-linux@rasmusvillemoes.dk> <9f1a846b-c303-92fa-9620-f492ef940de7@rasmusvillemoes.dk> From: Timur Tabi Message-ID: <02dd5acd-b81e-fde3-028c-16e754e846b5@kernel.org> Date: Fri, 15 Nov 2019 08:35:58 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <9f1a846b-c303-92fa-9620-f492ef940de7@rasmusvillemoes.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/15/19 2:01 AM, Rasmus Villemoes wrote: > That would be a separate patch, this patch is only concerned with > eliminating the implicit assumption of the host being big-endian. And > there's already been some pushback to adding arch-specific ifdefs (which > I agree with, but as I responded there see as the lesser evil), so > unless there's a very good reason to add that complexity, I'd rather not. We don't want to encourage people to introduce device trees that don't have the brg-frequency property in them. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34E60C432C3 for ; Fri, 15 Nov 2019 14:40:47 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8D0E2073A for ; Fri, 15 Nov 2019 14:40:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PDTXSN7Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8D0E2073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47F1HJ6JGszF7X3 for ; Sat, 16 Nov 2019 01:40:44 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=timur@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="PDTXSN7Q"; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47F19w1gDbzDrdC for ; Sat, 16 Nov 2019 01:36:03 +1100 (AEDT) Received: from [192.168.1.20] (cpe-24-28-70-126.austin.res.rr.com [24.28.70.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFF4D20733; Fri, 15 Nov 2019 14:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573828561; bh=zcYNaxA6BKLXVIrEibaKGpyyFgLeOOLcofq3PI+ecco=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=PDTXSN7Q9BNaGWYT00xceI6zye3VrA+/YAPDFdajMlZi3HFfpMSjCShVVI6ACm1LF CnqbEPAeehgHGiIY2k55fkCm49x2fbA6wLV6Nc4PC+UnE1OyQkQbkgM4Q6YT9F5OvD IAxsiV8AQN9KM3gn6gtoyf2oWlnTWcbGpB6r6kkQ= Subject: Re: [PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe() To: Rasmus Villemoes References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-33-linux@rasmusvillemoes.dk> <9f1a846b-c303-92fa-9620-f492ef940de7@rasmusvillemoes.dk> From: Timur Tabi Message-ID: <02dd5acd-b81e-fde3-028c-16e754e846b5@kernel.org> Date: Fri, 15 Nov 2019 08:35:58 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <9f1a846b-c303-92fa-9620-f492ef940de7@rasmusvillemoes.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lkml , Li Yang , Scott Wood , linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 11/15/19 2:01 AM, Rasmus Villemoes wrote: > That would be a separate patch, this patch is only concerned with > eliminating the implicit assumption of the host being big-endian. And > there's already been some pushback to adding arch-specific ifdefs (which > I agree with, but as I responded there see as the lesser evil), so > unless there's a very good reason to add that complexity, I'd rather not. We don't want to encourage people to introduce device trees that don't have the brg-frequency property in them. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D03C432C3 for ; Fri, 15 Nov 2019 14:36:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0996320733 for ; Fri, 15 Nov 2019 14:36:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X36dxN0H"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PDTXSN7Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0996320733 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9/kCIlfT74iUPIKH+foMubNzxVK/DiJ9HXQuxFgdMeM=; b=X36dxN0HYxIDjkpFYOpwTnKN+ 0Ccm48CPcMG+dMyw2tfXtqD4OgoufLiVymRJtpv+qcOQYWDrbqAcy0hFwjYxX0K4edq04MmFZWcnB IwA+tnPUuPBcTyVR+vbjetpt+1deWDKTY/jUZzM4BIRWec2+BALOYrrHSJs/3htiu7XZ8QO30nqvI Xrq4UCJ59m2/wVy1hyYp1fqiXx9Rtf9M3RS4jggg/FCvlmjc48VxC3msqkLfZhN7N92WnQbTYNxae na8f7yDntEsPHt5t7b0ARZKMPcJzUT6bTZPrOmKFiukRabffV6yGJlpgLMcx1aCZwga6eJfY6HaM/ Sm8vGo7QA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVchh-0004Zq-6z; Fri, 15 Nov 2019 14:36:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVche-0004ZJ-0Y for linux-arm-kernel@lists.infradead.org; Fri, 15 Nov 2019 14:36:03 +0000 Received: from [192.168.1.20] (cpe-24-28-70-126.austin.res.rr.com [24.28.70.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFF4D20733; Fri, 15 Nov 2019 14:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573828561; bh=zcYNaxA6BKLXVIrEibaKGpyyFgLeOOLcofq3PI+ecco=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=PDTXSN7Q9BNaGWYT00xceI6zye3VrA+/YAPDFdajMlZi3HFfpMSjCShVVI6ACm1LF CnqbEPAeehgHGiIY2k55fkCm49x2fbA6wLV6Nc4PC+UnE1OyQkQbkgM4Q6YT9F5OvD IAxsiV8AQN9KM3gn6gtoyf2oWlnTWcbGpB6r6kkQ= Subject: Re: [PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe() To: Rasmus Villemoes References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-33-linux@rasmusvillemoes.dk> <9f1a846b-c303-92fa-9620-f492ef940de7@rasmusvillemoes.dk> From: Timur Tabi Message-ID: <02dd5acd-b81e-fde3-028c-16e754e846b5@kernel.org> Date: Fri, 15 Nov 2019 08:35:58 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <9f1a846b-c303-92fa-9620-f492ef940de7@rasmusvillemoes.dk> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191115_063602_072716_F73C6D19 X-CRM114-Status: GOOD ( 10.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , lkml , Li Yang , Scott Wood , linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , Qiang Zhao Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/15/19 2:01 AM, Rasmus Villemoes wrote: > That would be a separate patch, this patch is only concerned with > eliminating the implicit assumption of the host being big-endian. And > there's already been some pushback to adding arch-specific ifdefs (which > I agree with, but as I responded there see as the lesser evil), so > unless there's a very good reason to add that complexity, I'd rather not. We don't want to encourage people to introduce device trees that don't have the brg-frequency property in them. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel