All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralph Boehme <slow@samba.org>
To: COMMON INTERNET FILE SYSTEM SERVER <linux-cifs@vger.kernel.org>
Cc: Steve French <smfrench@gmail.com>, Namjae Jeon <linkinjeon@kernel.org>
Subject: Building ksmbd as external module on kernel < 5.15
Date: Sat, 25 Sep 2021 11:15:55 +0200	[thread overview]
Message-ID: <040d44a6-5c7c-5053-6e03-8db045519c0a@samba.org> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 991 bytes --]

Hi!

I noticed two problems building ksmbd as external module from 
github.com:smfrench/smb3-kernel.git:

1. Need to manually export CONFIG_SMB_SERVER=m even though .config 
contains it.

2. Use of lookup_one() not present in kernels before 5.15.

See the following shell dump for the problems in action:

<https://cpaste.org/?cddf4595181c8c42#8HKBmcBcP8hE2RUhG3wi3QbsQmAXHDtVuMFYfeuYz7Lj>

Wrt 1: this was exported in Namjae's old git repo 
https://github.com/namjaejeon/ksmbd but was lost in the Makefile rewrite.

Wrt 2: it seems the patches included in 
https://github.com/namjaejeon/ksmbd around 
9caf6ed9f0b6c71b0bcc661b316e08172b7a6d55 are missing in 
github.com:smfrench/smb3-kernel.git.

How shall we address this? Is building the module on older kernels (I'm 
on 5.13.14-200.fc34.x86_64) actually supported?

Thanks!
-slow

-- 
Ralph Boehme, Samba Team                 https://samba.org/
SerNet Samba Team Lead      https://sernet.de/en/team-samba


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

             reply	other threads:[~2021-09-25  9:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-25  9:15 Ralph Boehme [this message]
2021-09-25  9:51 ` Building ksmbd as external module on kernel < 5.15 Ralph Boehme
2021-09-25 10:32   ` Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=040d44a6-5c7c-5053-6e03-8db045519c0a@samba.org \
    --to=slow@samba.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.