All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulraj, Sandeep <s-paulraj@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Quick sanity test after my NAND patches
Date: Fri, 6 Nov 2009 16:14:17 -0600	[thread overview]
Message-ID: <0554BEF07D437848AF01B9C9B5F0BC5D93D82FA6@dlee01.ent.ti.com> (raw)
In-Reply-To: <4AF49D1C.6060903@freescale.com>

Hello Scott,
 
> Paulraj, Sandeep wrote:
> >> I don't know if the technique will work for you (Sandeep), but for the
> >> libfdt synchronization, I literally extracted the patches from the
> >> master DTC repository (git format-patch) and applied them (git am).
> > This might not work as git-am will complain about not being able to
> apply clean.
> 
> You can apply the patches to your u-boot tree with git am, fixing up any
> conflicts, and then do format-patch on the results.
> 
> > Is it possible for you to let me know which patches you are OK with, so
> that I know what to resend?
> 
> I'm most concerned with getting the attribution right on the 'fix "raw"
> reads with ECC syndrome layouts' patch, since that adds significant new
> code -- but ideally any patches that correspond with a patch in Linux
> should look as much like that patch as possible (otherwise, mention in
> the changelog that it is a sync with Linux). 

So I take it that you only want the above patch resent with the correct signoffs.
I'll resend this single patch.
.
> Or if you meant which
> patches I'm OK with merging even after resend, they all look OK.
> 
> As for the comment about checkpatch warnings, what was it complaining
> about?  If it's not too bad I'd rather not make stylistic deviations
> from what made it into Linux.

80 chars per line warning. Do we really need to break this rule while I submit my patch?

Unrelated, but if you have a look at the subpage API, that's absolutely unbelievable; the function header itself is some 150 chars. I don't have a clue as to how it got accepted by the MTD folks.
> 
> -Scott


Also in response to another e-mail from you, I think we need to update nand_ecc.c as well. I'll do that as well as a separate patch.

Thanks,
Sandeep

      reply	other threads:[~2009-11-06 22:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-06 20:47 [U-Boot] Quick sanity test after my NAND patches Paulraj, Sandeep
2009-11-06 21:08 ` Scott Wood
2009-11-06 21:17   ` Jerry Van Baren
2009-11-06 21:28     ` Paulraj, Sandeep
2009-11-06 21:37       ` Jerry Van Baren
2009-11-06 21:44         ` Paulraj, Sandeep
2009-11-08 22:59         ` Wolfgang Denk
2009-11-06 22:03       ` Scott Wood
2009-11-06 22:14         ` Paulraj, Sandeep [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0554BEF07D437848AF01B9C9B5F0BC5D93D82FA6@dlee01.ent.ti.com \
    --to=s-paulraj@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.