All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
	Virtio-Dev <virtio-dev@lists.oasis-open.org>
Subject: [virtio-dev] queue_enable vs QueueReady
Date: Thu, 28 May 2020 21:06:36 +0800	[thread overview]
Message-ID: <0592979c-c8ae-fd28-2ddf-e64b135a7292@redhat.com> (raw)

Hi:

I found ambiguity in the virtio specification:

In PCI part, it describes the queue_enable as:

The driver uses this to selectively prevent the device from executing 
requests from this virtqueue. 1 - enabled; 0 - disabled.

In MMIO part, it describes the QueueReady as:

Writing one (0x1) to this register notifies the device that it can 
execute requests from this virtual queue. Reading from this register 
returns the last value written to it. Both read and write accesses apply 
to the queue selected by writing to QueueSel.

If I understand this correctly, they have the same meaning, but the 
driver requirements section looks conflict:

PCI said: The driver MUST NOT write a 0 to queue_enable.

MMIO said:

To stop using the queue the driver MUST write zero (0x0) to this 
QueueReady and MUST read the value back to ensure synchronization.

So we can't disable a queue via queue_enable but QueueReady. Any reason 
for such inconsistency?

Thanks


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


             reply	other threads:[~2020-05-28 13:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 13:06 Jason Wang [this message]
2020-05-28 14:00 ` [virtio-dev] queue_enable vs QueueReady Stefan Hajnoczi
2020-05-29  2:57   ` Jason Wang
2020-06-01  6:01 ` [virtio-dev] " Michael S. Tsirkin
2020-06-02  2:57   ` Jason Wang
2020-06-02  4:20     ` Michael S. Tsirkin
2020-06-02  6:46       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0592979c-c8ae-fd28-2ddf-e64b135a7292@redhat.com \
    --to=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.