From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Dmitry Bogdanov <d.bogdanov@yadro.com>
Cc: Martin Petersen <martin.petersen@oracle.com>,
"open list:SCSI TARGET SUBSYSTEM" <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
"linux@yadro.com" <linux@yadro.com>,
Nilesh Javali <njavali@marvell.com>,
"GR-QLogic-Storage-Upstream@marvell.com"
<GR-QLogic-Storage-Upstream@marvell.com>
Subject: Re: [PATCH] scsi: qla2xxx: restore initiator in dual mode
Date: Wed, 15 Sep 2021 15:41:54 +0000 [thread overview]
Message-ID: <059EE994-4578-4815-AFFE-CDBE27B095D3@oracle.com> (raw)
In-Reply-To: <20210915153239.8035-1-d.bogdanov@yadro.com>
> On Sep 15, 2021, at 10:32 AM, Dmitry Bogdanov <d.bogdanov@yadro.com> wrote:
>
> In dual mode in case of disabling the target, the whole port goes offline
> and Initiator is turned off too.
>
> This patch fixes restoring Initiator mode after disabling Target in dual mode.
>
> Fixes: 0645cb8350cd ("scsi: qla2xxx: Add mode control for each physical port")
> Signed-off-by: Dmitry Bogdanov <d.bogdanov@yadro.com>
> ---
> This patchset is intended for scsi-fix.
> ---
> drivers/scsi/qla2xxx/qla_init.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
> index 1e4e3e83b5c7..5fc7697f0af4 100644
> --- a/drivers/scsi/qla2xxx/qla_init.c
> +++ b/drivers/scsi/qla2xxx/qla_init.c
> @@ -7169,7 +7169,8 @@ qla2x00_abort_isp(scsi_qla_host_t *vha)
> return 0;
> break;
> case QLA2XXX_INI_MODE_DUAL:
> - if (!qla_dual_mode_enabled(vha))
> + if (!qla_dual_mode_enabled(vha) &&
> + !qla_ini_mode_enabled(vha))
> return 0;
> break;
> case QLA2XXX_INI_MODE_ENABLED:
> --
> 2.25.1
>
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
next prev parent reply other threads:[~2021-09-15 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 15:32 [PATCH] scsi: qla2xxx: restore initiator in dual mode Dmitry Bogdanov
2021-09-15 15:41 ` Himanshu Madhani [this message]
2021-09-22 4:44 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=059EE994-4578-4815-AFFE-CDBE27B095D3@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=d.bogdanov@yadro.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.