Re: [NXP-IMX] please pull nxp-imx-2021-4-6

From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Stefano Babic <sbabic@denx.de>,
	"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	Fabio Estevam <festevam@gmail.com>
Cc: u-boot <u-boot@lists.denx.de>
Subject: Re: [NXP-IMX] please pull nxp-imx-2021-4-6
Date: Thu, 27 May 2021 17:09:26 +0200	[thread overview]
Message-ID: <05f005ce-5c16-4e4f-f377-38d0e09dfd65@kontron.de> (raw)
In-Reply-To: <79e0acd8-d1f5-7005-dddf-c0e4c02f29bc@denx.de>

Hi Stefano,

On 27.05.21 16:59, Stefano Babic wrote:
> Hi Frieder,
> 
> On 27.05.21 16:47, Frieder Schrempf wrote:
>> Hi,
>>
>> On 06.04.21 11:34, Peng Fan (OSS) wrote:
>>> Hi Stefano,
>>>
>>> Please pull nxp-imx-2021-4-6. This PR is based on Tom's master branch. If you need
>>> me rebase on imx/master, I could redo this PR. This is quite a large PR, since lots
>>> stuff in downstream tree.
>>>
>>> I ran local buildman test for all boards, no issue found.
>>> ------------------------------------------
>>> convert to use binman for i.MX8MN/M/P EVK board
>>
>> It looks like these patches haven't been sent to the list. Is this common practice to have patches pulled via PR that were not sent to the list before?
> 
> Never. Patches *MUST* be sent to the ML. I am sorry if some patches were pulled by me and they were not in the ML: it is then a mistake. Anyway, my work-flow foresees to get patches from patchworks and update the status after merging, and it is weird if some patches were not posted.
> 
> For the patches reported here, they were posted and you get at:
> 
> https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D235820%26state%3D*&amp;data=04%7C01%7Cfrieder.schrempf%40kontron.de%7C6757587cd70a41af63f308d9211fff81%7C8c9d3c973fd941c8a2b1646f3942daf1%7C0%7C0%7C637577243581770096%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=AkXzKPgEtURhDXRY4tfdu4BjFCqOKBYYPyQ0JSXusn0%3D&amp;reserved=0
> 
> but again, if some patches were merged without beeing posted, it was just a big mistake. It should not happen !
> 
>> To me it feels wrong as there is no chance they will ever get reviewed/tested before merging,
> 
> You're right, and patches must be posted without exceptions.
> 
>> but I don't know the rules.
> 
> Your feeling is correct.

Thanks for clarifying and for pointing to patchwork. I should have been looking there before. Your link points to a different series, but I found the patches I was looking for here: http://patchwork.ozlabs.org/project/uboot/list/?series=237531&state=%2A&archive=both.

For some reason I can't find them in my mailbox, but that's probably a different story.

Thanks a lot!
Frieder