All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Ammar Faizi' <ammarfaizi2@gnuweeb.org>, Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Tony Luck <tony.luck@intel.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"gwml@vger.gnuweeb.org" <gwml@vger.gnuweeb.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"Alviro Iskandar Setiawan" <alviro.iskandar@gnuweeb.org>,
	Jiri Hladky <hladky.jiri@googlemail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: RE: [PATCH v4 1/2] x86/delay: Fix the wrong asm constraint in `delay_loop()`
Date: Tue, 1 Mar 2022 09:54:07 +0000	[thread overview]
Message-ID: <0642444da1844f8dae2dc98b34b8ab74@AcuMS.aculab.com> (raw)
In-Reply-To: <20220301094608.118879-2-ammarfaizi2@gnuweeb.org>

From: Ammar Faizi
> Sent: 01 March 2022 09:46
> 
> The asm constraint does not reflect that the asm statement can modify
> the value of @loops. But the asm statement in delay_loop() does change
> the @loops.
> 
> If by any chance the compiler inlines this function, it may clobber
> random stuff (e.g. local variable, important temporary value in reg,
> etc.).
> 
> Fortunately, delay_loop() is only called indirectly (so it can't
> inline), and then the register it clobbers is %rax (which is by the
> nature of the calling convention, it's a caller saved register), so it
> didn't yield any bug.

Both the function pointers in that code need killing.
They only have two options (each) so conditional branches
will almost certainly always have been better.

I also wonder how well the comment
   The additional jump magic is needed to get the timing stable
   on all the CPU' we have to worry about.
applies to any modern cpu!
The code is unchanged since (at least) 2.6.27.
(It might have been moved from another file.)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)


  reply	other threads:[~2022-03-01  9:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01  9:46 [PATCH v4 0/2] Two x86 fixes Ammar Faizi
2022-03-01  9:46 ` [PATCH v4 1/2] x86/delay: Fix the wrong asm constraint in `delay_loop()` Ammar Faizi
2022-03-01  9:54   ` David Laight [this message]
2022-03-03  0:14     ` Ammar Faizi
2022-03-01 11:33   ` Alviro Iskandar Setiawan
2022-03-03  0:06     ` Ammar Faizi
2022-03-03  0:35     ` David Laight
2022-03-01  9:46 ` [PATCH v4 2/2] x86/mce/amd: Fix memory leak when `threshold_create_bank()` fails Ammar Faizi
2022-03-02 17:26   ` Yazen Ghannam
2022-03-02 23:20     ` Ammar Faizi
2022-03-02 23:27       ` Ammar Faizi
2022-03-03  1:58         ` Alviro Iskandar Setiawan
2022-03-03  2:07           ` Ammar Faizi
2022-03-03  2:32             ` Ammar Faizi
2022-03-03  2:51               ` Alviro Iskandar Setiawan
2022-03-07  0:27               ` Ammar Faizi
2022-03-09 20:55                 ` Yazen Ghannam
2022-03-10  1:56                   ` Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0642444da1844f8dae2dc98b34b8ab74@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=alviro.iskandar@gnuweeb.org \
    --cc=ammarfaizi2@gnuweeb.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gwml@vger.gnuweeb.org \
    --cc=hladky.jiri@googlemail.com \
    --cc=hpa@zytor.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.