From: Julien Grall <julien.grall@arm.com>
To: Derek Straka <derek@asterius.io>, xen-devel@lists.xen.org
Cc: andrew.cooper3@citrix.com, jbeulich@suse.com
Subject: Re: [PATCH 1/2] x86: add a user configurable Kconfig option for the NS16550 UART
Date: Wed, 14 Sep 2016 10:42:04 +0100 [thread overview]
Message-ID: <071781b1-acba-5583-a6ea-9f844ba846ef@arm.com> (raw)
In-Reply-To: <1473788144-12113-1-git-send-email-derek@asterius.io>
Hello Derek,
On 13/09/16 18:35, Derek Straka wrote:
> Allows for the conditional inclusion of NS16550 UART driver on the x86 platform
> rather than having it always enabled.
>
> The default configuration for the HAS_NS16550 option remains 'y' on x86, so the
> behavior out of the box remains unchanged. The addition of the option allows
> advanced users to enable/disable the inclusion of the NS16550 UART driver.
>
> Signed-off-by: Derek Straka <derek@asterius.io>
> ---
> xen/arch/x86/Kconfig | 1 -
> xen/drivers/char/Kconfig | 4 ++--
> xen/include/xen/serial.h | 7 ++++++-
> 3 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
> index 265fd79..8a122df 100644
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -15,7 +15,6 @@ config X86
> select HAS_MEM_ACCESS
> select HAS_MEM_PAGING
> select HAS_MEM_SHARING
> - select HAS_NS16550
> select HAS_PASSTHROUGH
> select HAS_PCI
> select HAS_PDX
> diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
> index 51343d0..c87e018 100644
> --- a/xen/drivers/char/Kconfig
> +++ b/xen/drivers/char/Kconfig
> @@ -1,6 +1,6 @@
> config HAS_NS16550
> - bool
> - default y
> + bool "NS16550 UART" if EXPERT = "y"
> + default y if X86
> help
> This selects the 16550-series UART support. For most systems, say Y.
With this change, NS166550 is now disabled by default on ARM. This was
not the case before.
Please make sure to retain the previous behavior for ARM platforms.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-14 9:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 17:35 [PATCH 1/2] x86: add a user configurable Kconfig option for the NS16550 UART Derek Straka
2016-09-13 17:35 ` [PATCH 2/2] x86: add a user configurable Kconfig option for the EHCI UART Derek Straka
2016-09-13 17:43 ` Andrew Cooper
2016-09-14 9:43 ` Julien Grall
2016-09-14 10:41 ` Jan Beulich
2016-09-13 17:43 ` [PATCH 1/2] x86: add a user configurable Kconfig option for the NS16550 UART Andrew Cooper
2016-09-14 9:42 ` Julien Grall [this message]
2016-09-14 10:39 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=071781b1-acba-5583-a6ea-9f844ba846ef@arm.com \
--to=julien.grall@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=derek@asterius.io \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.