From: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Praveen Kumar Kannoju <praveen.kannoju@oracle.com>,
leon@kernel.org, dledford@redhat.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org,
Rajesh Sivaramasubramaniom
<rajesh.sivaramasubramaniom@oracle.com>,
Rama Nichanamatlu <rama.nichanamatlu@oracle.com>,
Jeffery Yoder <jeffery.yoder@oracle.com>
Subject: Re: [PATCH v2] IB/mlx5: Reduce max order of memory allocated for xlt update
Date: Tue, 23 Mar 2021 21:27:38 -0700 [thread overview]
Message-ID: <0DFF7518-8818-445B-94AC-8EB2096446BE@oracle.com> (raw)
In-Reply-To: <20210323231321.GF2710221@ziepe.ca>
> On Mar 23, 2021, at 4:13 PM, Jason Gunthorpe <jgg@ziepe.ca> wrote:
>
> On Tue, Mar 23, 2021 at 12:41:51PM -0700, Aruna Ramakrishna wrote:
>> There is a far greater possibility of an order-8 allocation failing,
>> esp. with the addition of __GFP_NORETRY , and the code would have to
>> fall back to a lower order allocation more often than not (esp. on a
>> long running system). Unless the performance gains from using order-8
>> pages is significant (and it does not seem that way to me), we can just
>> skip this step and directly go to the lower order allocation.
>
> Do not send HTML mails.
I apologize; I’ve fixed the setting now.
>
> Do you have benchmarks that show the performance of the high order
> pages is not relavent? I'm a bit surprised to hear that
>
I guess my point was more to the effect that an order-8 alloc will fail more often than not, in this flow. For instance, when we were debugging the latency spikes here, this was the typical buddyinfo output on that system:
Node 0, zone DMA 0 1 1 2 3 0 1 0 1 1 3
Node 0, zone DMA32 7 7 7 6 10 2 6 7 6 2 306
Node 0, zone Normal 3390 51354 17574 6556 1586 26 2 1 0 0 0
Node 1, zone Normal 11519 23315 23306 9738 73 2 0 1 0 0 0
I think this level of fragmentation is pretty normal on long running systems. Here, in the reg_mr flow, the first try (order-8) alloc will probably fail 9 times out of 10 (esp. after the addition of GFP_NORETRY flag), and then as fallback, the code tries to allocate a lower order, and if that too fails, it allocates a page. I think it makes sense to just avoid trying an order-8 alloc here.
Thanks,
Aruna
> This code really needs some attention to use a proper
> scatter/gather. I understand the chip can do it, just some of the
> software layers need to be stripped away so it can form the right SGL
> in the HW.
>
> Jason
next prev parent reply other threads:[~2021-03-24 4:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 13:09 [PATCH v2] IB/mlx5: Reduce max order of memory allocated for xlt update Praveen Kumar Kannoju
2021-03-23 13:42 ` Praveen Kannoju
2021-03-23 16:07 ` Jason Gunthorpe
[not found] ` <80966C8E-341B-4F5D-9DCA-C7D82AB084D5@oracle.com>
2021-03-23 23:13 ` Jason Gunthorpe
2021-03-24 4:27 ` Aruna Ramakrishna [this message]
2021-03-25 14:39 ` Jason Gunthorpe
2021-03-31 17:53 ` Jason Gunthorpe
2021-04-01 15:56 ` Praveen Kannoju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0DFF7518-8818-445B-94AC-8EB2096446BE@oracle.com \
--to=aruna.ramakrishna@oracle.com \
--cc=dledford@redhat.com \
--cc=jeffery.yoder@oracle.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=praveen.kannoju@oracle.com \
--cc=rajesh.sivaramasubramaniom@oracle.com \
--cc=rama.nichanamatlu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.