From: Haiying Wang <r54964@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/2] Add DO_SYNC at the end of flash_write_cmd
Date: Fri, 09 Feb 2007 12:47:37 -0500 [thread overview]
Message-ID: <1171043258.3932.21.camel@udp097531uds.am.freescale.net> (raw)
In-Reply-To: <45C179F0.6050206@orkun.us>
Make sure the flash write command is fully finished and remove the unnecessary ssync operation which should be moved to it CPU header file
Signed-off-by: Haiying Wang <haiying.wang@freescale.com>
---
drivers/cfi_flash.c | 15 +++------------
1 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/cfi_flash.c b/drivers/cfi_flash.c
index 696f9a4..c686e53 100644
--- a/drivers/cfi_flash.c
+++ b/drivers/cfi_flash.c
@@ -931,27 +931,18 @@ static void flash_write_cmd (flash_info_t * info, flash_sect_t sect, uint offset
debug ("fwc addr %p cmd %x %x 8bit x %d bit\n", addr.cp, cmd,
cword.c, info->chipwidth << CFI_FLASH_SHIFT_WIDTH);
*addr.cp = cword.c;
-#ifdef CONFIG_BLACKFIN
- asm("ssync;");
-#endif
break;
case FLASH_CFI_16BIT:
debug ("fwc addr %p cmd %x %4.4x 16bit x %d bit\n", addr.wp,
cmd, cword.w,
info->chipwidth << CFI_FLASH_SHIFT_WIDTH);
*addr.wp = cword.w;
-#ifdef CONFIG_BLACKFIN
- asm("ssync;");
-#endif
break;
case FLASH_CFI_32BIT:
debug ("fwc addr %p cmd %x %8.8lx 32bit x %d bit\n", addr.lp,
cmd, cword.l,
info->chipwidth << CFI_FLASH_SHIFT_WIDTH);
*addr.lp = cword.l;
-#ifdef CONFIG_BLACKFIN
- asm("ssync;");
-#endif
break;
case FLASH_CFI_64BIT:
#ifdef DEBUG
@@ -966,11 +957,11 @@ static void flash_write_cmd (flash_info_t * info, flash_sect_t sect, uint offset
}
#endif
*addr.llp = cword.ll;
-#ifdef CONFIG_BLACKFIN
- asm("ssync;");
-#endif
break;
}
+
+ /* Ensure all the instruction are finished */
+ DO_SYNC;
}
static void flash_unlock_seq (flash_info_t * info, flash_sect_t sect)
--
1.4.4.4
next prev parent reply other threads:[~2007-02-09 17:47 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-22 7:27 [U-Boot-Users] [PATCH] Fixed cfi flash read uchar bug wei.zhang at freescale.com
2006-12-22 10:00 ` Wolfgang Denk
2006-12-22 11:02 ` Zhang Wei
2006-12-22 14:11 ` Wolfgang Denk
2006-12-22 16:34 ` [U-Boot-Users] 答复: " Zhang Wei-r63237
2006-12-22 17:17 ` Wolfgang Denk
2006-12-25 7:03 ` Zhang Wei
2006-12-25 23:24 ` Wolfgang Denk
2006-12-26 6:04 ` Zhang Wei
2007-01-04 2:07 ` Zhang Wei-r63237
2007-01-04 8:17 ` Wolfgang Denk
2007-01-04 8:36 ` Zhang Wei-r63237
2007-01-04 9:23 ` Wolfgang Denk
2007-01-04 11:19 ` Stefan Roese
2007-01-05 13:27 ` Stefan Roese
2007-01-07 10:12 ` Tolunay Orkun
2007-01-07 10:40 ` Wolfgang Denk
2007-01-13 7:11 ` Tolunay Orkun
2007-01-13 17:53 ` Håvard Skinnemoen
2007-01-16 6:52 ` Stefan Roese
2007-01-25 4:38 ` Zhang Wei-r63237
2007-01-25 16:10 ` Timur Tabi
2007-01-25 20:33 ` Wolfgang Denk
2007-01-26 2:13 ` Zhang Wei-r63237
2007-01-29 11:29 ` Tolunay Orkun
2007-01-30 3:36 ` Wang Haiying-r54964
2007-01-31 9:01 ` Tolunay Orkun
2007-01-31 19:25 ` Haiying Wang
2007-02-01 5:26 ` Tolunay Orkun
2007-02-01 22:06 ` Haiying Wang
2007-02-01 22:52 ` Chris Fester
2007-02-09 17:47 ` [U-Boot-Users] [PATCH0/2] Re-do the patch for adding DO_SYNC in flash_write_cmd Haiying Wang
2007-02-09 19:42 ` Wolfgang Denk
2007-02-09 19:48 ` Haiying Wang
2007-02-10 1:04 ` Wolfgang Denk
2007-02-10 7:23 ` Tolunay Orkun
2007-02-10 7:40 ` Stefan Roese
2007-02-10 7:57 ` Tolunay Orkun
2007-02-10 8:07 ` Stefan Roese
2007-02-10 21:55 ` Wolfgang Denk
2007-02-10 21:54 ` Wolfgang Denk
2007-02-11 2:34 ` Timur Tabi
2007-02-11 10:23 ` Wolfgang Denk
2007-02-09 19:59 ` Haavard Skinnemoen
2007-02-10 1:02 ` Wolfgang Denk
2007-02-09 17:47 ` Haiying Wang [this message]
2007-02-09 19:45 ` [U-Boot-Users] [PATCH 1/2] Add DO_SYNC at the end of flash_write_cmd Wolfgang Denk
2007-02-09 17:47 ` [U-Boot-Users] [PATCH 2/2] Define DO_SYNC in each CPU's header file Haiying Wang
2007-02-09 19:46 ` Wolfgang Denk
2007-02-10 7:17 ` Tolunay Orkun
2007-01-08 2:41 ` [U-Boot-Users] [PATCH] Fixed cfi flash read uchar bug Zhang Wei-r63237
2006-12-22 17:07 ` Chris Fester
2006-12-22 17:24 ` Wolfgang Denk
2006-12-22 17:42 ` Chris Fester
2006-12-22 21:33 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1171043258.3932.21.camel@udp097531uds.am.freescale.net \
--to=r54964@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.