From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org
Subject: [JGIT PATCH 0/5] RevWalk fixes for UNINTERESTING
Date: Thu, 12 Mar 2009 19:07:37 -0700 [thread overview]
Message-ID: <1236910062-18476-1-git-send-email-spearce@spearce.org> (raw)
Today I uncovered some ugly cases with "jgit rev-list B ^A", where
some commits reachable from A were still being output, even though
we asked that they be excluded.
This series attempts to fix it by forcing date ordering, and delaying
output a little to try and work over any clock skew discovered near
the end of the traversal, just before we give up.
Shawn O. Pearce (5):
Show critical flags in debug toString() descriptions of rev queues
Make RevObject.getType implementations final
Remove the horribly stupid RevSort.START_ORDER
Fix RevWalk with Linus Torvald's occasional bad commit date hack
Avoid incorrect output of UNINTERESTING commits when clock skew
occurs
.../org/spearce/jgit/revwalk/AbstractRevQueue.java | 5 +
.../src/org/spearce/jgit/revwalk/DateRevQueue.java | 10 +--
.../org/spearce/jgit/revwalk/DelayRevQueue.java | 92 ++++++++++++++++++++
.../src/org/spearce/jgit/revwalk/FIFORevQueue.java | 10 +--
.../jgit/revwalk/FixUninterestingGenerator.java | 77 ++++++++++++++++
.../src/org/spearce/jgit/revwalk/LIFORevQueue.java | 10 +--
.../org/spearce/jgit/revwalk/PendingGenerator.java | 59 +++++++++++--
.../src/org/spearce/jgit/revwalk/RevBlob.java | 2 +-
.../src/org/spearce/jgit/revwalk/RevCommit.java | 15 +++-
.../src/org/spearce/jgit/revwalk/RevObject.java | 24 +++++
.../src/org/spearce/jgit/revwalk/RevSort.java | 11 ---
.../src/org/spearce/jgit/revwalk/RevTag.java | 2 +-
.../src/org/spearce/jgit/revwalk/RevTree.java | 2 +-
.../src/org/spearce/jgit/revwalk/RevWalk.java | 6 +-
.../org/spearce/jgit/revwalk/StartGenerator.java | 27 ++++--
15 files changed, 296 insertions(+), 56 deletions(-)
create mode 100644 org.spearce.jgit/src/org/spearce/jgit/revwalk/DelayRevQueue.java
create mode 100644 org.spearce.jgit/src/org/spearce/jgit/revwalk/FixUninterestingGenerator.java
next reply other threads:[~2009-03-13 2:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 2:07 Shawn O. Pearce [this message]
2009-03-13 2:07 ` [JGIT PATCH 1/5] Show critical flags in debug toString() descriptions of rev queues Shawn O. Pearce
2009-03-13 2:07 ` [JGIT PATCH 2/5] Make RevObject.getType implementations final Shawn O. Pearce
2009-03-13 2:07 ` [JGIT PATCH 3/5] Remove the horribly stupid RevSort.START_ORDER Shawn O. Pearce
2009-03-13 2:07 ` [JGIT PATCH 4/5] Fix RevWalk with Linus Torvald's occasional bad commit date hack Shawn O. Pearce
2009-03-13 2:07 ` [JGIT PATCH 5/5] Avoid incorrect output of UNINTERESTING commits when clock skew occurs Shawn O. Pearce
2009-03-14 0:54 ` [JGIT PATCH 4/5 v2] Fix RevWalk with Linus Torvald's occasional bad commit date hack Shawn O. Pearce
2009-03-13 20:00 ` [JGIT PATCH 0/5] RevWalk fixes for UNINTERESTING Robin Rosenberg
2009-03-13 22:39 ` [JGIT PATCH 0/6] Add tests for RevWalk and its supporting code Shawn O. Pearce
2009-03-14 0:13 ` Shawn O. Pearce
2009-03-14 0:56 ` [JGIT PATCH 6/5 v2] " Shawn O. Pearce
2009-03-15 11:34 ` Robin Rosenberg
2009-03-16 14:33 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236910062-18476-1-git-send-email-spearce@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.