From: James Bottomley <James.Bottomley@suse.de>
To: ayan@marvell.com
Cc: jeff@garzik.org, linux-scsi@vger.kernel.org, jfeng@marvell.com,
qswang@marvell.com
Subject: Re: [PATCH 2/7]MVSAS:add supporting MSI feature
Date: Sat, 14 Nov 2009 12:19:17 -0600 [thread overview]
Message-ID: <1258222757.4070.34.camel@mulgrave.site> (raw)
In-Reply-To: <20091109120818.GA32336@Andy.marvell.com>
On Mon, 2009-11-09 at 20:08 +0800, Andy Yan wrote:
> From 8b51aa63e8b123046a334d630ae045f479acbf6c Mon Sep 17 00:00:00 2001
> From: andy <ayan@marvell.com>
> Date: Fri, 6 Nov 2009 17:03:21 +0800
> Subject: [PATCH 2/7] Add supporting MSI feature
>
> MSI feature is implemented with mvsas driver.
>
> Signed-off-by: Andy <ayan@marvell.com>
> Signed-off-by: Jacky <jfeng@marvell.com>
> Signed-off-by: Ke <kewei@marvell.com>
This doesn't compile:
CC [M] drivers/scsi/mvsas/mv_init.o
drivers/scsi/mvsas/mv_init.c: In function ‘mvs_enable_msi’:
drivers/scsi/mvsas/mv_init.c:197: error: ‘PCR_CMD’ undeclared (first use in this function)
drivers/scsi/mvsas/mv_init.c:197: error: (Each undeclared identifier is reported only once
drivers/scsi/mvsas/mv_init.c:197: error: for each function it appears in.)
drivers/scsi/mvsas/mv_init.c:201: error: ‘PCR_MSI_CTRL’ undeclared (first use in this function)
drivers/scsi/mvsas/mv_init.c: In function ‘mvs_disable_msi’:
drivers/scsi/mvsas/mv_init.c:208: error: ‘PCR_CMD’ undeclared (first use in this function)
drivers/scsi/mvsas/mv_init.c:212: error: ‘PCR_MSI_CTRL’ undeclared (first use in this function)
It looks like these definitions are added in patch 3 (after this
one) ... you can't do that: a patch series has to be bisectable
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-11-14 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 12:08 [PATCH 2/7]MVSAS:add supporting MSI feature Andy Yan
2009-11-14 18:19 ` James Bottomley [this message]
2009-11-14 22:56 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258222757.4070.34.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=ayan@marvell.com \
--cc=jeff@garzik.org \
--cc=jfeng@marvell.com \
--cc=linux-scsi@vger.kernel.org \
--cc=qswang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.