From: Adam Jackson <ajax@redhat.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: Small series to enable OpRegion->VBT
Date: Tue, 24 Aug 2010 10:22:48 -0400 [thread overview]
Message-ID: <1282659768.17843.37718.camel@atropine> (raw)
In-Reply-To: <1282639383-26988-1-git-send-email-chris@chris-wilson.co.uk>
[-- Attachment #1.1: Type: text/plain, Size: 982 bytes --]
On Tue, 2010-08-24 at 09:42 +0100, Chris Wilson wrote:
> This looks to be a useful set of patches that enable VBT parsing on
> machines with only a compressed VBIOS and so provide fixed-panel modes
> for my netbooks. In conjunction with this, I then hit an issue where the
> BIOS writers became creative in their use of VBT and so I needed a small
> patch to lvds_is_present_in_vbt() to account for the new brain damage.
> After Adam's insight, we just accept the VBT without question if it came
> from OpRegion.
I'd be a little more comfortable with this series if we tried to find
VBT in VBIOS first. The way around you have it in patch 3 we'll likely
be changing behaviour on existing machines, since we've not been paying
any attention to what OpRegion's VBT contains before now. I mean, I'm
not going to insist on it, but I'll reserve the right to say I told you
so.
But either way, for the series:
Reviewed-by: Adam Jackson <ajax@redhat.com>
- ajax
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2010-08-24 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 8:42 Small series to enable OpRegion->VBT Chris Wilson
2010-08-24 8:43 ` [PATCH 1/4] drm/i915: Allocate the PCI resource for the MCHBAR Chris Wilson
2010-08-24 19:25 ` Jesse Barnes
2010-08-24 8:43 ` [PATCH 2/4] drm/i915: Rename i915_opregion.c to intel_opregion.c Chris Wilson
2010-08-24 8:43 ` [PATCH 3/4] drm/i915: Use the VBT from OpRegion when available (v3) Chris Wilson
2010-08-24 8:43 ` [PATCH 4/4] drm/i915: Addin-offset is an unreliable indicator of LVDS presence (v2) Chris Wilson
2010-08-24 14:22 ` Adam Jackson [this message]
2010-08-24 14:37 ` Small series to enable OpRegion->VBT Chris Wilson
2010-08-24 15:42 ` Adam Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282659768.17843.37718.camel@atropine \
--to=ajax@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.