From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760202Ab2D0OLu (ORCPT ); Fri, 27 Apr 2012 10:11:50 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:42759 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759990Ab2D0OLs (ORCPT ); Fri, 27 Apr 2012 10:11:48 -0400 Message-ID: <1335535895.25521.7.camel@joe2Laptop> Subject: Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers From: Joe Perches To: Borislav Petkov Cc: Mauro Carvalho Chehab , Linux Edac Mailing List , Linux Kernel Mailing List , Aristeu Rozanski , Doug Thompson , Mark Gross , Jason Uhlenkott , Tim Small , Ranganathan Desikan , "Arvind R." , Olof Johansson , Egor Martovetsky , Chris Metcalf , Michal Marek , Jiri Kosina , Dmitry Eremin-Solenikov , Benjamin Herrenschmidt , Hitoshi Mitake , Andrew Morton , Niklas =?ISO-8859-1?Q?S=F6derlund?= , Shaohui Xie , Josh Boyer , linuxppc-dev@lists.ozlabs.org Date: Fri, 27 Apr 2012 10:11:35 -0400 In-Reply-To: <20120427133304.GE9626@aftab.osrc.amd.com> References: <1335289087-11337-1-git-send-email-mchehab@redhat.com> <1335291342-14922-1-git-send-email-mchehab@redhat.com> <20120427133304.GE9626@aftab.osrc.amd.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2012-04-27 at 15:33 +0200, Borislav Petkov wrote: > this patch gives > > [ 8.278399] EDAC DEBUG: new_edac_mc_alloc: new_edac_mc_alloc: 0: dimm0 (0:0:0): row 0, chan 0 One too many __func__'s in some combination of the pr_fmt and/or dbg call and/or the actual call site? > > diff --git a/drivers/edac/edac_core.h b/drivers/edac/edac_core.h [] > > @@ -447,8 +447,13 @@ static inline void pci_write_bits32(struct pci_dev *pdev, int offset, > > > > #endif /* CONFIG_PCI */ > > > > -extern struct mem_ctl_info *edac_mc_alloc(unsigned sz_pvt, unsigned nr_csrows, > > - unsigned nr_chans, int edac_index); > > +struct mem_ctl_info *edac_mc_alloc(unsigned sz_pvt, unsigned nr_csrows, > > + unsigned nr_chans, int edac_index); > > Why not "extern"? Using extern function prototypes in .h files isn't generally necessary nor is extern the more common kernel style. > > +static inline void edac_mc_handle_ce(struct mem_ctl_info *mci, > > unsigned long page_frame_number, > > unsigned long offset_in_page, > > unsigned long syndrome, int row, int channel, > > - const char *msg); > > Strange alignment, pls do > > static inline void edac_mc_handle_ce(struct..., > unsigned..., > ..., > ...); > or static inline void edac_mc_handle_ce(struct ..., etc) or static inline void edac_mc_handle_ce(...) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from labridge.com (perches-mx.perches.com [206.117.179.246]) (using SSLv3 with cipher DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0064EB6FA3 for ; Sat, 28 Apr 2012 00:11:50 +1000 (EST) Message-ID: <1335535895.25521.7.camel@joe2Laptop> Subject: Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers From: Joe Perches To: Borislav Petkov Date: Fri, 27 Apr 2012 10:11:35 -0400 In-Reply-To: <20120427133304.GE9626@aftab.osrc.amd.com> References: <1335289087-11337-1-git-send-email-mchehab@redhat.com> <1335291342-14922-1-git-send-email-mchehab@redhat.com> <20120427133304.GE9626@aftab.osrc.amd.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: Mauro Carvalho Chehab , Jason Uhlenkott , Aristeu Rozanski , Hitoshi Mitake , Shaohui Xie , Mark Gross , Dmitry Eremin-Solenikov , Ranganathan Desikan , Egor Martovetsky , Niklas =?ISO-8859-1?Q?S=F6derlund?= , Tim Small , "Arvind R." , Chris Metcalf , Doug Thompson , Andrew Morton , Linux Edac Mailing List , Michal Marek , Jiri Kosina , Linux Kernel Mailing List , Olof Johansson , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2012-04-27 at 15:33 +0200, Borislav Petkov wrote: > this patch gives > > [ 8.278399] EDAC DEBUG: new_edac_mc_alloc: new_edac_mc_alloc: 0: dimm0 (0:0:0): row 0, chan 0 One too many __func__'s in some combination of the pr_fmt and/or dbg call and/or the actual call site? > > diff --git a/drivers/edac/edac_core.h b/drivers/edac/edac_core.h [] > > @@ -447,8 +447,13 @@ static inline void pci_write_bits32(struct pci_dev *pdev, int offset, > > > > #endif /* CONFIG_PCI */ > > > > -extern struct mem_ctl_info *edac_mc_alloc(unsigned sz_pvt, unsigned nr_csrows, > > - unsigned nr_chans, int edac_index); > > +struct mem_ctl_info *edac_mc_alloc(unsigned sz_pvt, unsigned nr_csrows, > > + unsigned nr_chans, int edac_index); > > Why not "extern"? Using extern function prototypes in .h files isn't generally necessary nor is extern the more common kernel style. > > +static inline void edac_mc_handle_ce(struct mem_ctl_info *mci, > > unsigned long page_frame_number, > > unsigned long offset_in_page, > > unsigned long syndrome, int row, int channel, > > - const char *msg); > > Strange alignment, pls do > > static inline void edac_mc_handle_ce(struct..., > unsigned..., > ..., > ...); > or static inline void edac_mc_handle_ce(struct ..., etc) or static inline void edac_mc_handle_ce(...)