From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754798Ab2D1Uio (ORCPT ); Sat, 28 Apr 2012 16:38:44 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:48115 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753065Ab2D1Uim (ORCPT ); Sat, 28 Apr 2012 16:38:42 -0400 Message-ID: <1335645521.4191.13.camel@joe2Laptop> Subject: Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers From: Joe Perches To: Borislav Petkov Cc: Mauro Carvalho Chehab , Linux Edac Mailing List , Linux Kernel Mailing List , Aristeu Rozanski , Doug Thompson , Mark Gross , Jason Uhlenkott , Tim Small , Ranganathan Desikan , "Arvind R." , Olof Johansson , Egor Martovetsky , Chris Metcalf , Michal Marek , Jiri Kosina , Dmitry Eremin-Solenikov , Benjamin Herrenschmidt , Hitoshi Mitake , Andrew Morton , Niklas =?ISO-8859-1?Q?S=F6derlund?= , Shaohui Xie , Josh Boyer , linuxppc-dev@lists.ozlabs.org Date: Sat, 28 Apr 2012 13:38:41 -0700 In-Reply-To: <20120428085223.GB26065@aftab.osrc.amd.com> References: <1335289087-11337-1-git-send-email-mchehab@redhat.com> <1335291342-14922-1-git-send-email-mchehab@redhat.com> <20120427133304.GE9626@aftab.osrc.amd.com> <1335535895.25521.7.camel@joe2Laptop> <4F9AC44A.5000509@redhat.com> <20120428085223.GB26065@aftab.osrc.amd.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2012-04-28 at 10:52 +0200, Borislav Petkov wrote: > On Fri, Apr 27, 2012 at 01:07:38PM -0300, Mauro Carvalho Chehab wrote: > > Yes. This is a common issue at the EDAC core: on several places, it calls the > > edac debug macros (DEBUGF0...DEBUGF4) passing a __func__ as an argument, while > > the debug macros already handles that. I suspect that, in the past, the __func__ > > were not at the macros, but some patch added it there, and forgot to fix the > > occurrences of its call. > > The patch that added it is d357cbb445208 and you reviewed it. > > > This is something that needs to be reviewed at the entire EDAC core (and likely > > at the drivers). > > Looks like a job for a newbie to get her/his feet wet with kernel work. Looks to me more like a lazy maintainer/developer who doesn't want to bother with a few minutes work. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from labridge.com (perches-mx.perches.com [206.117.179.246]) (using SSLv3 with cipher DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CC836B6FE9 for ; Sun, 29 Apr 2012 06:38:44 +1000 (EST) Message-ID: <1335645521.4191.13.camel@joe2Laptop> Subject: Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers From: Joe Perches To: Borislav Petkov Date: Sat, 28 Apr 2012 13:38:41 -0700 In-Reply-To: <20120428085223.GB26065@aftab.osrc.amd.com> References: <1335289087-11337-1-git-send-email-mchehab@redhat.com> <1335291342-14922-1-git-send-email-mchehab@redhat.com> <20120427133304.GE9626@aftab.osrc.amd.com> <1335535895.25521.7.camel@joe2Laptop> <4F9AC44A.5000509@redhat.com> <20120428085223.GB26065@aftab.osrc.amd.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: Mauro Carvalho Chehab , Jason Uhlenkott , Aristeu Rozanski , Hitoshi Mitake , Shaohui Xie , Mark Gross , Dmitry Eremin-Solenikov , Ranganathan Desikan , Egor Martovetsky , Niklas =?ISO-8859-1?Q?S=F6derlund?= , Tim Small , "Arvind R." , Chris Metcalf , Doug Thompson , Andrew Morton , Linux Edac Mailing List , Michal Marek , Jiri Kosina , Linux Kernel Mailing List , Olof Johansson , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 2012-04-28 at 10:52 +0200, Borislav Petkov wrote: > On Fri, Apr 27, 2012 at 01:07:38PM -0300, Mauro Carvalho Chehab wrote: > > Yes. This is a common issue at the EDAC core: on several places, it calls the > > edac debug macros (DEBUGF0...DEBUGF4) passing a __func__ as an argument, while > > the debug macros already handles that. I suspect that, in the past, the __func__ > > were not at the macros, but some patch added it there, and forgot to fix the > > occurrences of its call. > > The patch that added it is d357cbb445208 and you reviewed it. > > > This is something that needs to be reviewed at the entire EDAC core (and likely > > at the drivers). > > Looks like a job for a newbie to get her/his feet wet with kernel work. Looks to me more like a lazy maintainer/developer who doesn't want to bother with a few minutes work.