From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5EFFC4727C for ; Wed, 30 Sep 2020 18:57:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B010120708 for ; Wed, 30 Sep 2020 18:57:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730679AbgI3S5H (ORCPT ); Wed, 30 Sep 2020 14:57:07 -0400 Received: from smtprelay0017.hostedemail.com ([216.40.44.17]:36204 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730263AbgI3S5E (ORCPT ); Wed, 30 Sep 2020 14:57:04 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id B102C2C9D; Wed, 30 Sep 2020 18:57:03 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: soap41_0b0aa1027195 X-Filterd-Recvd-Size: 2464 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf15.hostedemail.com (Postfix) with ESMTPA; Wed, 30 Sep 2020 18:57:01 +0000 (UTC) Message-ID: <133589afbe999347454dfcc46ae782897bf9e3a2.camel@perches.com> Subject: Re: [PATCH v2] srcu: avoid escaped section names From: Joe Perches To: sedat.dilek@gmail.com, Nick Desaulniers Cc: "Paul E . McKenney" , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Josh Triplett , Kees Cook , linux-kernel@vger.kernel.org, rcu@vger.kernel.org, Clang-Built-Linux ML Date: Wed, 30 Sep 2020 11:57:00 -0700 In-Reply-To: References: <20200929192549.501516-1-ndesaulniers@google.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-09-30 at 18:41 +0200, Sedat Dilek wrote: > On Tue, Sep 29, 2020 at 9:25 PM 'Nick Desaulniers' via Clang Built > Linux wrote: > > The stringification operator, `#`, in the preprocessor escapes strings. > > For example, `# "foo"` becomes `"\"foo\""`. GCC and Clang differ in how > > they treat section names that contain \". > > > > The portable solution is to not use a string literal with the > > preprocessor stringification operator. > > > > Link: https://bugs.llvm.org/show_bug.cgi?id=42950 > > Fixes: commit fe15b50cdeee ("srcu: Allocate per-CPU data for DEFINE_SRCU() in modules") > > Signed-off-by: Nick Desaulniers > > Puh, remember one year ago an overnight bisecting to catch the root > cause for "escaped section names". > > The two patches I see - this here and "export.h: fix section name for > CONFIG_TRIM_UNUSED_KSYMS for Clang" were new cases? > > Do we have a check-script to catch/avoid such cases (Joe Perches?)? Try the script that removes #S from #define __section(S) https://lore.kernel.org/lkml/0e582a7f5144a33f465978d97701f9b3dcc377f3.camel@perches.com/