All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: QEMU-devel <qemu-devel@nongnu.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Xen Devel <xen-devel@lists.xen.org>,
	Stefano Stabellini <stefano.stabellini@citrix.com>,
	Avi Kivity <avi@redhat.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: [PATCH 3/4] exec, memory: Call to xen_modified_memory.
Date: Tue, 17 Jul 2012 14:30:04 +0100	[thread overview]
Message-ID: <1342531805-29894-4-git-send-email-anthony.perard__34927.8338872411$1342531959$gmane$org@citrix.com> (raw)
In-Reply-To: <1342531805-29894-1-git-send-email-anthony.perard@citrix.com>

This patch add some calls to xen_modified_memory to notify Xen about dirtybits
during migration.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 exec.c   |    4 ++++
 memory.c |    2 ++
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/exec.c b/exec.c
index c9fa17d..9f7a4f7 100644
--- a/exec.c
+++ b/exec.c
@@ -3438,6 +3438,7 @@ void cpu_physical_memory_rw(target_phys_addr_t addr, uint8_t *buf,
                     cpu_physical_memory_set_dirty_flags(
                         addr1, (0xff & ~CODE_DIRTY_FLAG));
                 }
+                xen_modified_memory(addr1, TARGET_PAGE_SIZE);
                 qemu_put_ram_ptr(ptr);
             }
         } else {
@@ -3623,6 +3624,7 @@ void cpu_physical_memory_unmap(void *buffer, target_phys_addr_t len,
     if (buffer != bounce.buffer) {
         if (is_write) {
             ram_addr_t addr1 = qemu_ram_addr_from_host_nofail(buffer);
+            xen_modified_memory(addr1, access_len);
             while (access_len) {
                 unsigned l;
                 l = TARGET_PAGE_SIZE;
@@ -3947,6 +3949,7 @@ static inline void stl_phys_internal(target_phys_addr_t addr, uint32_t val,
             cpu_physical_memory_set_dirty_flags(addr1,
                 (0xff & ~CODE_DIRTY_FLAG));
         }
+        xen_modified_memory(addr1, 4);
     }
 }
 
@@ -4020,6 +4023,7 @@ static inline void stw_phys_internal(target_phys_addr_t addr, uint32_t val,
             cpu_physical_memory_set_dirty_flags(addr1,
                 (0xff & ~CODE_DIRTY_FLAG));
         }
+        xen_modified_memory(addr1, 2);
     }
 }
 
diff --git a/memory.c b/memory.c
index aab4a31..4d004e2 100644
--- a/memory.c
+++ b/memory.c
@@ -19,6 +19,7 @@
 #include "bitops.h"
 #include "kvm.h"
 #include <assert.h>
+#include "hw/xen.h"
 
 #define WANT_EXEC_OBSOLETE
 #include "exec-obsolete.h"
@@ -1085,6 +1086,7 @@ void memory_region_set_dirty(MemoryRegion *mr, target_phys_addr_t addr,
                              target_phys_addr_t size)
 {
     assert(mr->terminates);
+    xen_modified_memory(mr->ram_addr + addr, size);
     return cpu_physical_memory_set_dirty_range(mr->ram_addr + addr, size, -1);
 }
 
-- 
Anthony PERARD

  parent reply	other threads:[~2012-07-17 13:30 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17 13:30 [Qemu-devel] [PATCH 0/4] Xen, introducing dirty log for migration Anthony PERARD
2012-07-17 13:30 ` [Qemu-devel] [PATCH 1/4] QMP, Introduce set-global-dirty-log command Anthony PERARD
2012-07-17 13:57   ` Eric Blake
2012-07-17 13:57   ` Eric Blake
2012-07-17 13:58   ` Avi Kivity
2012-07-17 13:58   ` [Qemu-devel] " Avi Kivity
2012-07-17 17:58     ` Stefano Stabellini
2012-07-17 17:58     ` [Qemu-devel] " Stefano Stabellini
2012-07-18  8:30       ` Avi Kivity
2012-07-18  8:30       ` Avi Kivity
2012-07-17 13:30 ` Anthony PERARD
2012-07-17 13:30 ` [Qemu-devel] [PATCH 2/4] xen: Introduce xen_modified_memory Anthony PERARD
2012-07-17 13:30 ` Anthony PERARD
2012-07-17 13:30 ` [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory Anthony PERARD
2012-07-17 13:37   ` Avi Kivity
2012-07-17 13:59     ` Anthony PERARD
2012-07-17 14:44       ` Avi Kivity
2012-07-17 14:44       ` Avi Kivity
2012-07-17 18:36         ` Stefano Stabellini
2012-07-18  8:32           ` Avi Kivity
2012-07-18  8:32           ` Avi Kivity
2012-07-19 11:41           ` Anthony PERARD
2012-07-19 11:41           ` Anthony PERARD
2012-07-19 11:50             ` Avi Kivity
2012-07-19 14:27               ` Anthony PERARD
2012-07-19 14:27               ` Anthony PERARD
2012-07-19 11:50             ` Avi Kivity
2012-07-17 18:36         ` Stefano Stabellini
2012-07-17 13:59     ` Anthony PERARD
2012-07-17 13:37   ` Avi Kivity
2012-07-17 18:06   ` Stefano Stabellini
2012-07-17 18:06   ` [Qemu-devel] " Stefano Stabellini
2012-07-19 12:34     ` Paolo Bonzini
2012-07-19 12:34     ` [Qemu-devel] " Paolo Bonzini
2012-07-19 15:37       ` Stefano Stabellini
2012-07-19 15:41         ` Anthony PERARD
2012-07-19 15:41         ` Anthony PERARD
2012-07-19 15:37       ` Stefano Stabellini
2012-07-17 13:30 ` Anthony PERARD [this message]
2012-07-17 13:30 ` [PATCH 4/4] xen: Always set the vram dirty during migration Anthony PERARD
2012-07-17 13:30 ` [Qemu-devel] " Anthony PERARD
2012-07-17 18:25   ` Stefano Stabellini
2012-07-17 18:25   ` [Qemu-devel] " Stefano Stabellini
2012-07-17 18:30     ` Stefano Stabellini
2012-07-20 14:11       ` Anthony PERARD
2012-07-20 14:11       ` [Qemu-devel] " Anthony PERARD
2012-07-20 15:47         ` Stefano Stabellini
2012-07-20 15:47         ` [Qemu-devel] " Stefano Stabellini
2012-07-17 18:30     ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1342531805-29894-4-git-send-email-anthony.perard__34927.8338872411$1342531959$gmane$org@citrix.com' \
    --to=anthony.perard@citrix.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.