All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Alex Shi <alex.shi@intel.com>, X86-ML <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Borislav Petkov <borislav.petkov@amd.com>
Subject: [PATCH v1 2/4] x86, CPU: Push TLB detection CPUID check down
Date: Mon,  6 Aug 2012 19:00:37 +0200	[thread overview]
Message-ID: <1344272439-29080-3-git-send-email-bp@amd64.org> (raw)
In-Reply-To: <1344272439-29080-1-git-send-email-bp@amd64.org>

From: Borislav Petkov <borislav.petkov@amd.com>

Push the max CPUID leaf check into the ->detect_tlb function and remove
general test case from the generic path.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
 arch/x86/kernel/cpu/common.c | 3 +--
 arch/x86/kernel/cpu/intel.c  | 4 ++++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index d239977f361f..080f4a737e3e 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -940,8 +940,7 @@ void __init identify_boot_cpu(void)
 #else
 	vgetcpu_set_mode();
 #endif
-	if (boot_cpu_data.cpuid_level >= 2)
-		cpu_detect_tlb(&boot_cpu_data);
+	cpu_detect_tlb(&boot_cpu_data);
 }
 
 void __cpuinit identify_secondary_cpu(struct cpuinfo_x86 *c)
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index 0a4ce2980a5a..198e019a531a 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -648,6 +648,10 @@ static void __cpuinit intel_detect_tlb(struct cpuinfo_x86 *c)
 	int i, j, n;
 	unsigned int regs[4];
 	unsigned char *desc = (unsigned char *)regs;
+
+	if (c->cpuid_level < 2)
+		return;
+
 	/* Number of times to iterate */
 	n = cpuid_eax(2) & 0xFF;
 
-- 
1.7.11.rc1


  parent reply	other threads:[~2012-08-06 17:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-06 17:00 [PATCH v1 0/4] x86, CPU: TLB flushall shift, the AMD side Borislav Petkov
2012-08-06 17:00 ` [PATCH v1 1/4] x86, CPU: Fixup tlb_flushall_shift formatting Borislav Petkov
2012-08-07  3:07   ` [tip:x86/mm] x86, cpu: " tip-bot for Borislav Petkov
2012-08-06 17:00 ` Borislav Petkov [this message]
2012-08-07  0:35   ` [PATCH v1 2/4] x86, CPU: Push TLB detection CPUID check down Alex Shi
2012-08-07  3:08   ` [tip:x86/mm] x86, cpu: " tip-bot for Borislav Petkov
2012-08-06 17:00 ` [PATCH v1 3/4] x86, CPU: Add AMD TLB size detection Borislav Petkov
2012-08-07  3:09   ` [tip:x86/mm] x86, cpu: " tip-bot for Borislav Petkov
2012-08-06 17:00 ` [PATCH v1 4/4] x86, CPU: Preset default tlb_flushall_shift on AMD Borislav Petkov
2012-08-07  3:10   ` [tip:x86/mm] x86, cpu: " tip-bot for Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344272439-29080-3-git-send-email-bp@amd64.org \
    --to=bp@amd64.org \
    --cc=alex.shi@intel.com \
    --cc=borislav.petkov@amd.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.