Re: strange behaviour from "make localmodconfig" throws out ath9k stuff

From: Steven Rostedt <rostedt@goodmis.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: strange behaviour from "make localmodconfig" throws out ath9k stuff
Date: Mon, 29 Apr 2013 19:40:09 -0400	[thread overview]
Message-ID: <1367278809.30667.33.camel@gandalf.local.home> (raw)
In-Reply-To: <alpine.DEB.2.02.1304291636380.16617@oneiric>

On Mon, 2013-04-29 at 16:39 -0400, Robert P. J. Day wrote:

>   i'm interested -- should that Kconfig file have been written using a
> different structure to avoid this issue? surely there are other
> Kconfig files that would have had the same problem, no? i can't
> believe this could be restricted to a single example involving
> atheros stuff.

I did a quick search and there's lots of places that source is within if
statements. But the config used isn't usually a tristate. That is, it is
either enabled or not, but can't be a module.

Here the if condition was a module and is something that localmodconfig
can disabled.

Hmm, I did find another case like this (and there may be more).

drivers/ipack/Kconfig does it too. But nobody noticed.

Anyway, it's fixed now, which is good.

-- Steve