From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753777Ab3EJIRi (ORCPT ); Fri, 10 May 2013 04:17:38 -0400 Received: from sauhun.de ([89.238.76.85]:60576 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753660Ab3EJIRe (ORCPT ); Fri, 10 May 2013 04:17:34 -0400 From: Wolfram Sang To: linux-kernel@vger.kernel.org Cc: Wolfram Sang , Florian Tobias Schandinat , linux-fbdev@vger.kernel.org Subject: [RFC 32/42] drivers/video: don't check resource with devm_ioremap_resource Date: Fri, 10 May 2013 10:17:17 +0200 Message-Id: <1368173847-5661-33-git-send-email-wsa@the-dreams.de> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1368173847-5661-1-git-send-email-wsa@the-dreams.de> References: <1368173847-5661-1-git-send-email-wsa@the-dreams.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/video/mxsfb.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 1b2c26d..3dc3265 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -883,12 +883,6 @@ static int mxsfb_probe(struct platform_device *pdev) if (of_id) pdev->id_entry = of_id->data; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, "Cannot get memory IO resource\n"); - return -ENODEV; - } - fb_info = framebuffer_alloc(sizeof(struct mxsfb_info), &pdev->dev); if (!fb_info) { dev_err(&pdev->dev, "Failed to allocate fbdev\n"); @@ -897,6 +891,7 @@ static int mxsfb_probe(struct platform_device *pdev) host = to_imxfb_host(fb_info); + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); host->base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(host->base)) { dev_err(&pdev->dev, "ioremap failed\n"); -- 1.7.10.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Date: Fri, 10 May 2013 08:17:17 +0000 Subject: [RFC 32/42] drivers/video: don't check resource with devm_ioremap_resource Message-Id: <1368173847-5661-33-git-send-email-wsa@the-dreams.de> List-Id: References: <1368173847-5661-1-git-send-email-wsa@the-dreams.de> In-Reply-To: <1368173847-5661-1-git-send-email-wsa@the-dreams.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org Cc: Wolfram Sang , Florian Tobias Schandinat , linux-fbdev@vger.kernel.org devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/video/mxsfb.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 1b2c26d..3dc3265 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -883,12 +883,6 @@ static int mxsfb_probe(struct platform_device *pdev) if (of_id) pdev->id_entry = of_id->data; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, "Cannot get memory IO resource\n"); - return -ENODEV; - } - fb_info = framebuffer_alloc(sizeof(struct mxsfb_info), &pdev->dev); if (!fb_info) { dev_err(&pdev->dev, "Failed to allocate fbdev\n"); @@ -897,6 +891,7 @@ static int mxsfb_probe(struct platform_device *pdev) host = to_imxfb_host(fb_info); + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); host->base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(host->base)) { dev_err(&pdev->dev, "ioremap failed\n"); -- 1.7.10.4